Storage: Refactor for fixing recreate Storage instance#8701
Merged
ti-chi-bot[bot] merged 4 commits intopingcap:masterfrom Jan 18, 2024
Merged
Storage: Refactor for fixing recreate Storage instance#8701ti-chi-bot[bot] merged 4 commits intopingcap:masterfrom
ti-chi-bot[bot] merged 4 commits intopingcap:masterfrom
Conversation
Contributor
Author
|
/run-all-tests |
JinheLin
approved these changes
Jan 18, 2024
Lloyd-Pottiger
approved these changes
Jan 18, 2024
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JinheLin, Lloyd-Pottiger The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Contributor
[LGTM Timeline notifier]Timeline:
|
ti-chi-bot
pushed a commit
to ti-chi-bot/tiflash
that referenced
this pull request
Jan 18, 2024
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
Member
|
In response to a cherrypick label: new pull request created to branch |
12 tasks
JaySon-Huang
added a commit
to ti-chi-bot/tiflash
that referenced
this pull request
Jan 25, 2024
12 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: ref #8695
Problem Summary:
What is changed and how it works?
This is a pre-refactor PR for making the real logic change more clearly. #8698
Storages/DeltaMerge/StoragePoolGlobalStoragePool,StoragePoolandStoragePoolConfigCheck List
Tests
Side effects
Documentation
Release note