ddl: Fix the storage instance may be physically dropped when the region is not removed (#8721)#8724
Merged
ti-chi-bot[bot] merged 5 commits intopingcap:release-7.5from Jan 26, 2024
Conversation
12 tasks
c327a00 to
b23daac
Compare
Contributor
|
/run-all-tests |
1 similar comment
Contributor
|
/run-all-tests |
b655d72 to
2c41f99
Compare
Contributor
|
/run-all-tests |
Contributor
|
/hold |
Lloyd-Pottiger
approved these changes
Jan 26, 2024
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
f5efc1f to
1f77eda
Compare
Contributor
|
/run-all-tests |
Lloyd-Pottiger
approved these changes
Jan 26, 2024
Contributor
|
@Lloyd-Pottiger: Your lgtm message is repeated, so it is ignored. DetailsIn response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Comment on lines
+401
to
+403
| updateTiFlashReplicaNumOnStorage(database_id, table_id, storage, table_info); | ||
| // FIXME: Do not drop the table under release-7.5 branch, need more testing | ||
| // applyDropTable(database_id, table_id, "SetTiFlashReplica-0"); |
Contributor
There was a problem hiding this comment.
When the tiflash replica is set to 0, do not drop the IStorage instance under release-7.5 branch
Contributor
|
Contributor
|
/run-integration-test |
JaySon-Huang
approved these changes
Jan 26, 2024
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JaySon-Huang, Lloyd-Pottiger The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Contributor
[LGTM Timeline notifier]Timeline:
|
Contributor
|
/unhold |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an automated cherry-pick of #8721
What problem does this PR solve?
Issue Number: close #8710
Problem Summary:
There are some case that a region may not be removed from TiFlash when there are unhealth peers rule_checker @ pd. However, after the tiflash replica is set to zero, the data still be physically dropped after gc safepoint exceed.
What is changed and how it works?
* Throw exception when the storage instance is not exist after schema syncedCheck List
Tests
Side effects
Documentation
Release note