Skip to content

ddl: Add the reason why an IStorage instance is recovered#8735

Merged
ti-chi-bot[bot] merged 3 commits intopingcap:masterfrom
JaySon-Huang:add_ddl_reason
Jan 26, 2024
Merged

ddl: Add the reason why an IStorage instance is recovered#8735
ti-chi-bot[bot] merged 3 commits intopingcap:masterfrom
JaySon-Huang:add_ddl_reason

Conversation

@JaySon-Huang
Copy link
Contributor

@JaySon-Huang JaySon-Huang commented Jan 26, 2024 •
edited
Loading

What problem does this PR solve?

Issue Number: ref #6233

Problem Summary:

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed do-not-merge/needs-linked-issue labels Jan 26, 2024
@JaySon-Huang
Copy link
Contributor Author

JaySon-Huang commented Jan 26, 2024

/run-all-tests

@JaySon-Huang JaySon-Huang mentioned this pull request Jan 26, 2024
Merged
12 tasks
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Jan 26, 2024
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jan 26, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JinheLin, Lloyd-Pottiger

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [JinheLin,Lloyd-Pottiger]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jan 26, 2024
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jan 26, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-01-26 07:32:27.022865231 +0000 UTC m=+1118788.587162938: ☑️ agreed by Lloyd-Pottiger.
  • 2024-01-26 07:34:35.807082816 +0000 UTC m=+1118917.371380522: ☑️ agreed by JinheLin.

@JaySon-Huang
Copy link
Contributor Author

JaySon-Huang commented Jan 26, 2024

/run-unit-test

@JaySon-Huang JaySon-Huang self-assigned this Jan 26, 2024
@JaySon-Huang
Copy link
Contributor Author

JaySon-Huang commented Jan 26, 2024

/run-unit-test

@ti-chi-bot ti-chi-bot bot merged commit 764712b into pingcap:master Jan 26, 2024
@JaySon-Huang JaySon-Huang deleted the add_ddl_reason branch January 29, 2024 02:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JinheLin JinheLin JinheLin approved these changes

@Lloyd-Pottiger Lloyd-Pottiger Lloyd-Pottiger approved these changes

@hongyunyan hongyunyan Awaiting requested review from hongyunyan

Assignees

@JaySon-Huang JaySon-Huang

Labels

approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@JaySon-Huang @JinheLin @Lloyd-Pottiger