Skip to content

extract some base images to improve ci build#70

Merged
zanmato1984 merged 3 commits intopingcap:masterfrom
zyguan:improve-tics-builder
May 16, 2019
Merged

extract some base images to improve ci build#70
zanmato1984 merged 3 commits intopingcap:masterfrom
zyguan:improve-tics-builder

Conversation

@zyguan
Copy link
Contributor

@zyguan zyguan commented May 15, 2019

This PR tries to make CI build stable and fast.

@zyguan
Copy link
Contributor Author

zyguan commented May 16, 2019

/rebuild

1 similar comment
@zyguan
Copy link
Contributor Author

zyguan commented May 16, 2019

/rebuild

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tics-builder:base? not tics-builder-base?

@zanmato1984
Copy link
Contributor

We can now disable test build to fasten CI build.

Also, we can assume this PR the final shape that runs other PR, meaning don't mind other pending PRs. You can overwrite the exiting tics-builder image.

@zyguan
Copy link
Contributor Author

zyguan commented May 16, 2019

/rebuild

4 similar comments
@zyguan
Copy link
Contributor Author

zyguan commented May 16, 2019

/rebuild

@zyguan
Copy link
Contributor Author

zyguan commented May 16, 2019

/rebuild

@zyguan
Copy link
Contributor Author

zyguan commented May 16, 2019

/rebuild

@zyguan
Copy link
Contributor Author

zyguan commented May 16, 2019

/rebuild

Copy link
Contributor

@zanmato1984 zanmato1984 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zyguan
Copy link
Contributor Author

zyguan commented May 16, 2019

/rebuild

1 similar comment
@zyguan
Copy link
Contributor Author

zyguan commented May 16, 2019

/rebuild

@zyguan zyguan changed the title [WIP] extract some base images to improve ci build extract some base images to improve ci build May 16, 2019
@zyguan
Copy link
Contributor Author

zyguan commented May 16, 2019

/rebuild

@zyguan
Copy link
Contributor Author

zyguan commented May 16, 2019

/run-integration-tests

@zanmato1984 zanmato1984 merged commit e3c0948 into pingcap:master May 16, 2019
@zanmato1984
Copy link
Contributor

Thanks @zyguan for the effort to make our CI better!

@zanmato1984 zanmato1984 deleted the improve-tics-builder branch May 16, 2019 07:53
guo-shaoge pushed a commit to guo-shaoge/tiflash that referenced this pull request Nov 29, 2023
* cherry-pick pingcap#70

Signed-off-by: iosmanthus <myosmanthustree@gmail.com>

* cherry-pick region table utils and schema syncer

Signed-off-by: iosmanthus <myosmanthustree@gmail.com>

* polish comments

Signed-off-by: iosmanthus <myosmanthustree@gmail.com>

* fix schemaSync while restore tiflash replica

Signed-off-by: iosmanthus <myosmanthustree@gmail.com>

* exec format-diff.py

Signed-off-by: iosmanthus <myosmanthustree@gmail.com>

* add comments for HandleHttpRequestSyncRegion

Signed-off-by: iosmanthus <myosmanthustree@gmail.com>

* Refine the logging

---------

Signed-off-by: iosmanthus <myosmanthustree@gmail.com>
Co-authored-by: JaySon-Huang <tshent@qq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants