Skip to content

Add more information to the error message in MPPTunnel#6787

Merged
ti-chi-bot merged 2 commits intopingcap:masterfrom
windtalker:add_more_logs
Feb 9, 2023
Merged

Add more information to the error message in MPPTunnel#6787
ti-chi-bot merged 2 commits intopingcap:masterfrom
windtalker:add_more_logs

Conversation

@windtalker
Copy link
Contributor

@windtalker windtalker commented Feb 9, 2023

Signed-off-by: xufei xufeixw@mail.ustc.edu.cn

What problem does this PR solve?

Issue Number: ref #6233

Problem Summary:

What is changed and how it works?

  1. Add more information to the error message in MPPTunnel
  2. Use warning log when ExchangeReceiver::connectionDone is called with meet_error = true

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Feb 9, 2023 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • gengliqi
  • yibin87

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 9, 2023
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Feb 9, 2023
yibin87
yibin87 approved these changes Feb 9, 2023
View reviewed changes
Copy link
Contributor

@yibin87 yibin87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Feb 9, 2023
@windtalker
Copy link
Contributor Author

windtalker commented Feb 9, 2023

/merge

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Feb 9, 2023

@windtalker: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Feb 9, 2023

This pull request has been accepted and is ready to merge.

DetailsCommit hash: a0d447e

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Feb 9, 2023
@ti-chi-bot ti-chi-bot closed this Feb 9, 2023
@windtalker windtalker reopened this Feb 9, 2023
@windtalker
Copy link
Contributor Author

windtalker commented Feb 9, 2023

/merge

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Feb 9, 2023

@windtalker: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Feb 9, 2023

@windtalker: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

trigger some heavy tests which will not run always when PR updated.

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@windtalker
refine log
6cc87b0 
Signed-off-by: xufei <xufeixw@mail.ustc.edu.cn>
@windtalker
fix ut
ddc2454 
Signed-off-by: xufei <xufeixw@mail.ustc.edu.cn>
@ti-chi-bot ti-chi-bot removed the status/can-merge Indicates a PR has been approved by a committer. label Feb 9, 2023
@windtalker
Copy link
Contributor Author

windtalker commented Feb 9, 2023

/merge

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Feb 9, 2023

@windtalker: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Feb 9, 2023

This pull request has been accepted and is ready to merge.

DetailsCommit hash: ddc2454

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Feb 9, 2023
@gengliqi
Copy link
Contributor

gengliqi commented Feb 9, 2023

/run-unit-test

@ti-chi-bot ti-chi-bot merged commit 2480a1d into pingcap:master Feb 9, 2023
@windtalker windtalker deleted the add_more_logs branch February 9, 2023 07:20
guo-shaoge pushed a commit to guo-shaoge/tiflash that referenced this pull request Feb 10, 2023
@windtalker @guo-shaoge
Add more information to the error message in MPPTunnel (pingcap#6787)
0d25d4d 
ref pingcap#6233
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yibin87 yibin87 yibin87 approved these changes

@gengliqi gengliqi gengliqi approved these changes

Assignees

No one assigned

Labels

release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@windtalker @ti-chi-bot @gengliqi @yibin87