Skip to content

remove legacy code in RegionPersister#6781

Merged
ti-chi-bot merged 3 commits intopingcap:masterfrom
lidezhu:remove-legacy-region-persister-code
Feb 8, 2023
Merged

remove legacy code in RegionPersister#6781
ti-chi-bot merged 3 commits intopingcap:masterfrom
lidezhu:remove-legacy-region-persister-code

Conversation

@lidezhu
Copy link
Contributor

@lidezhu lidezhu commented Feb 8, 2023 •
edited
Loading

What problem does this PR solve?

Issue Number: ref #6728

Problem Summary: stable_page_storage is useless which stands for V1 format page data. This format is really too old and should be able to read by V2 format related code.

What is changed and how it works?

Remove stable_page_storage from RegionPersister.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Feb 8, 2023 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • JaySon-Huang
  • Lloyd-Pottiger

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/needs-linked-issue release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed do-not-merge/needs-linked-issue labels Feb 8, 2023
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Feb 8, 2023
@lidezhu
Copy link
Contributor Author

lidezhu commented Feb 8, 2023

/rebuild

@lidezhu lidezhu mentioned this pull request Feb 8, 2023
Merged
12 tasks
@lidezhu
Copy link
Contributor Author

lidezhu commented Feb 8, 2023

/run-all-tests

@lidezhu lidezhu requested a review from JaySon-Huang February 8, 2023 13:46
@JaySon-Huang
Copy link
Contributor

JaySon-Huang commented Feb 8, 2023

/merge

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Feb 8, 2023
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Feb 8, 2023

@JaySon-Huang: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Feb 8, 2023

This pull request has been accepted and is ready to merge.

DetailsCommit hash: 380fb46

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Feb 8, 2023
@ti-chi-bot ti-chi-bot merged commit 2500b2d into pingcap:master Feb 8, 2023
@lidezhu lidezhu deleted the remove-legacy-region-persister-code branch February 8, 2023 15:10
guo-shaoge pushed a commit to guo-shaoge/tiflash that referenced this pull request Feb 10, 2023
@lidezhu @guo-shaoge
remove legacy code in RegionPersister (pingcap#6781)
9f8724e 
ref pingcap#6728
ywqzzy pushed a commit to ywqzzy/tiflash_1 that referenced this pull request Feb 13, 2023
@lidezhu @ywqzzy
remove legacy code in RegionPersister (pingcap#6781)
9d6152a 
ref pingcap#6728

Signed-off-by: ywqzzy <592838129@qq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JaySon-Huang JaySon-Huang JaySon-Huang approved these changes

@Lloyd-Pottiger Lloyd-Pottiger Lloyd-Pottiger approved these changes

Assignees

No one assigned

Labels

release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@lidezhu @ti-chi-bot @JaySon-Huang @Lloyd-Pottiger