Add switch for disabling refined local tunnel by xzhangxian1008 · Pull Request #6683 · pingcap/tiflash

xzhangxian1008 · 2023-01-29T03:25:57Z

What problem does this PR solve?

Issue Number: close #6681 ref #6713

Problem Summary:

What is changed and how it works?

Check List

Tests

Unit test
Integration test
Manual test (add detailed scripts or steps below)
No code

Side effects

Performance regression: Consumes more CPU
Performance regression: Consumes more Memory
Breaking backward compatibility

Documentation

Release note

None

ti-chi-bot · 2023-01-29T03:25:59Z

[REVIEW NOTIFICATION]

This pull request has been approved by:

SeaRise
windtalker

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

xzhangxian1008 · 2023-01-29T03:26:10Z

/cc @SeaRise @windtalker

windtalker · 2023-01-29T03:50:25Z

dbms/src/Interpreters/Settings.h

                                                                                                                                                                                                                                        \
-    M(SettingBool, enable_planner, true, "Enable planner")
+    M(SettingBool, enable_planner, true, "Enable planner") \
+    M(SettingBool, enable_refined_local_tunnel, true, "Enable refined local tunnel")


I think we can use local_tunnel_version instead?

I think we can use local_tunnel_version instead?

okk

xzhangxian1008 · 2023-02-01T02:38:41Z

/hold

…_rf_local

ti-chi-bot · 2023-02-07T01:14:24Z

@hongyunyan: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot · 2023-02-07T01:14:25Z

This pull request has been accepted and is ready to merge.

Details

Commit hash: fac66cb

…nto switch_rf_local

ywqzzy · 2023-02-07T05:38:21Z

/merge

ti-chi-bot · 2023-02-07T05:38:23Z

@ywqzzy: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot · 2023-02-07T05:38:24Z

This pull request has been accepted and is ready to merge.

Details

Commit hash: 5464159

xzhangxian1008 · 2023-02-07T06:08:44Z

/run-integration-test

…nto switch_rf_local

xzhangxian1008 · 2023-02-07T07:24:22Z

/run-unit-test

…nto switch_rf_local

xzhangxian1008 · 2023-02-07T08:46:17Z

/run-all-tests

Lloyd-Pottiger · 2023-02-07T09:41:08Z

/merge

ti-chi-bot · 2023-02-07T09:41:10Z

@Lloyd-Pottiger: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot · 2023-02-07T09:41:11Z

This pull request has been accepted and is ready to merge.

Details

Commit hash: 5102a16

close pingcap#6681 Signed-off-by: ywqzzy <592838129@qq.com>

init

098658f

ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jan 29, 2023

ti-chi-bot requested review from SeaRise and windtalker January 29, 2023 03:26

windtalker reviewed Jan 29, 2023

View reviewed changes

xzhangxian1008 added 3 commits January 31, 2023 11:54

merge

5a6584b

merge

d516427

merge

494a0fb

ti-chi-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 31, 2023

ti-chi-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 1, 2023

xzhangxian1008 added 2 commits February 1, 2023 10:52

resolve comment

121174a

Merge branch 'master' of ssh://github.com/pingcap/tiflash into switch…

53c9626

…_rf_local

ti-chi-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 1, 2023

xzhangxian1008 requested review from SeaRise and windtalker and removed request for SeaRise and windtalker February 1, 2023 02:53

Merge branch 'master' of ssh://github.com/pingcap/tiflash into switch…

909e982

…_rf_local

ti-chi-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 2, 2023

merge

075a3d1

ti-chi-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Feb 2, 2023

fix

5e978b5

ti-chi-bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 2, 2023

ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Feb 7, 2023

ti-chi-bot and others added 3 commits February 7, 2023 11:00

Merge branch 'master' into switch_rf_local

d7a1a38

fix ut

841a45a

Merge branch 'switch_rf_local' of github.com:xzhangxian1008/tiflash i…

5464159

…nto switch_rf_local

ti-chi-bot removed the status/can-merge Indicates a PR has been approved by a committer. label Feb 7, 2023

ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Feb 7, 2023

ti-chi-bot and others added 4 commits February 7, 2023 14:12

Merge branch 'master' into switch_rf_local

19ade5b

Merge branch 'master' into switch_rf_local

3ec48be

fix ut

b5728c7

Merge branch 'switch_rf_local' of github.com:xzhangxian1008/tiflash i…

7b3de3c

…nto switch_rf_local

ti-chi-bot removed the status/can-merge Indicates a PR has been approved by a committer. label Feb 7, 2023

xzhangxian1008 added 2 commits February 7, 2023 15:29

Merge branch 'switch_rf_local' of github.com:xzhangxian1008/tiflash i…

153a3b6

…nto switch_rf_local

fix ut

5102a16

ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Feb 7, 2023

ti-chi-bot added 2 commits February 7, 2023 17:41

Merge branch 'master' into switch_rf_local

f3f36bc

Merge branch 'master' into switch_rf_local

ce8683b

ti-chi-bot merged commit 2830317 into pingcap:master Feb 7, 2023

xzhangxian1008 deleted the switch_rf_local branch February 7, 2023 14:13

ywqzzy pushed a commit to ywqzzy/tiflash_1 that referenced this pull request Feb 13, 2023

Add switch for disabling refined local tunnel (pingcap#6683)

8937156

close pingcap#6681 Signed-off-by: ywqzzy <592838129@qq.com>

Conversation

xzhangxian1008 commented Jan 29, 2023 • edited by solotzg Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What problem does this PR solve?

What is changed and how it works?

Check List

Release note

Uh oh!

ti-chi-bot commented Jan 29, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

xzhangxian1008 commented Jan 29, 2023

Uh oh!

windtalker Jan 29, 2023

Choose a reason for hiding this comment

Uh oh!

SeaRise Jan 29, 2023

Choose a reason for hiding this comment

Uh oh!

xzhangxian1008 Jan 29, 2023

Choose a reason for hiding this comment

Uh oh!

xzhangxian1008 commented Feb 1, 2023

Uh oh!

ti-chi-bot commented Feb 7, 2023

Uh oh!

ti-chi-bot commented Feb 7, 2023

Uh oh!

ywqzzy commented Feb 7, 2023

Uh oh!

ti-chi-bot commented Feb 7, 2023

Uh oh!

ti-chi-bot commented Feb 7, 2023

Uh oh!

xzhangxian1008 commented Feb 7, 2023

Uh oh!

xzhangxian1008 commented Feb 7, 2023

Uh oh!

xzhangxian1008 commented Feb 7, 2023

Uh oh!

Lloyd-Pottiger commented Feb 7, 2023

Uh oh!

ti-chi-bot commented Feb 7, 2023

Uh oh!

ti-chi-bot commented Feb 7, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

xzhangxian1008 commented Jan 29, 2023 •

edited by solotzg

Loading

ti-chi-bot commented Jan 29, 2023 •

edited

Loading