Skip to content

Collect request unit for tiflash compute#6649

Merged
ti-chi-bot merged 62 commits intopingcap:masterfrom
SeaRise:acu
Feb 8, 2023
Merged

Collect request unit for tiflash compute#6649
ti-chi-bot merged 62 commits intopingcap:masterfrom
SeaRise:acu

Conversation

@SeaRise
Copy link
Contributor

@SeaRise SeaRise commented Jan 17, 2023 •
edited
Loading

What problem does this PR solve?

Issue Number: close #6678

Problem Summary:

What is changed and how it works?

  • add conf cluster.cluster_id and held by InstanceLabelHolder
  • add metrics tiflash_compute_cpu_time_second and add labels cluster_id, process_id; process_id = compute_${host_name}_${start_unix_time}
  • add method collectRequestUnit for QueryExecutor and collect cpu time second for mpp, cop and batchCop
  • add method collectCPUTimeNs for IBlockInputStream
  • add toRU to convert cpu_time_ns to request unit

SvbAUbrSIe

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jan 17, 2023 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • bestwoody
  • windtalker

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/needs-linked-issue release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jan 17, 2023
@SeaRise SeaRise changed the title [DNM] [DNM] collect cpu time Jan 17, 2023
@SeaRise
Copy link
Contributor Author

SeaRise commented Jan 17, 2023

/run-all-tests

@SeaRise
Copy link
Contributor Author

SeaRise commented Jan 18, 2023

/rebuild

@SeaRise
Copy link
Contributor Author

SeaRise commented Jan 18, 2023

/run-all-tests

@SeaRise SeaRise changed the title [DNM] collect cpu time [WIP] collect cpu time Jan 28, 2023
@ti-chi-bot ti-chi-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 28, 2023
@SeaRise SeaRise changed the title [WIP] collect cpu time collect cpu time of mpp query Jan 30, 2023
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Feb 6, 2023
windtalker
windtalker approved these changes Feb 7, 2023
View reviewed changes
Copy link
Contributor

@windtalker windtalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Feb 7, 2023
@SeaRise
Copy link
Contributor Author

SeaRise commented Feb 7, 2023

/hold cputime or ru

@ti-chi-bot ti-chi-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 7, 2023
@SeaRise
Copy link
Contributor Author

SeaRise commented Feb 7, 2023

/hold

@SeaRise SeaRise changed the title Collect cpu time second for tiflash compute Collect request unit for tiflash compute Feb 8, 2023
@SeaRise
Copy link
Contributor Author

SeaRise commented Feb 8, 2023

/run-all-tests

@SeaRise
Copy link
Contributor Author

SeaRise commented Feb 8, 2023

/hold cancel

@ti-chi-bot ti-chi-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 8, 2023
@SeaRise
Copy link
Contributor Author

SeaRise commented Feb 8, 2023

/run-all-tests

@SeaRise
Copy link
Contributor Author

SeaRise commented Feb 8, 2023

/merge

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Feb 8, 2023

@SeaRise: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Feb 8, 2023

This pull request has been accepted and is ready to merge.

DetailsCommit hash: 4e067e1

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Feb 8, 2023
@ti-chi-bot ti-chi-bot merged commit dc7179d into pingcap:master Feb 8, 2023
@SeaRise SeaRise deleted the acu branch February 9, 2023 05:12
guo-shaoge pushed a commit to guo-shaoge/tiflash that referenced this pull request Feb 10, 2023
@SeaRise @guo-shaoge
Collect request unit for tiflash compute (pingcap#6649)
8981dfa 
close pingcap#6678
ywqzzy pushed a commit to ywqzzy/tiflash_1 that referenced this pull request Feb 13, 2023
@SeaRise @ywqzzy
Collect request unit for tiflash compute (pingcap#6649)
e2f94aa 
close pingcap#6678

Signed-off-by: ywqzzy <592838129@qq.com>
@SeaRise SeaRise mentioned this pull request Oct 31, 2023
Open
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@windtalker windtalker windtalker approved these changes

@guo-shaoge guo-shaoge Awaiting requested review from guo-shaoge

+1 more reviewer

@bestwoody bestwoody bestwoody approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Collect cpu time second for tiflash compute

4 participants

@SeaRise @ti-chi-bot @bestwoody @windtalker