Optimize exchange operator & Support mpp version#6596
Optimize exchange operator & Support mpp version#6596ti-chi-bot merged 104 commits intopingcap:masterfrom
Conversation
Signed-off-by: Zhigao Tong <tongzhigao@pingcap.com>
Signed-off-by: Zhigao Tong <tongzhigao@pingcap.com>
Signed-off-by: Zhigao Tong <tongzhigao@pingcap.com>
Signed-off-by: Zhigao Tong <tongzhigao@pingcap.com>
|
/merge |
|
@solotzg: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests You only need to trigger If you have any questions about the PR merge process, please refer to pr process. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
|
This pull request has been accepted and is ready to merge. DetailsCommit hash: e5376a5 |
|
/hold |
|
/rebuild |
|
/run-integration-test |
|
/merge |
|
@solotzg: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests You only need to trigger If you have any questions about the PR merge process, please refer to pr process. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
|
/run-unit-test |
|
/run-all-tests |
|
/unhold |
close pingcap#6620 Signed-off-by: Zhigao Tong <tongzhigao@pingcap.com>
close pingcap#6620 Signed-off-by: Zhigao Tong <tongzhigao@pingcap.com>
close pingcap#6620 Signed-off-by: Zhigao Tong
close pingcap#6620 Signed-off-by: ywqzzy <592838129@qq.com>
What problem does this PR solve?
Issue Number: close #6620
Problem Summary:
What is changed and how it works?
Base Modules & Utils
-march=haswellflag for a few modulesavx2_byte_countto optimizesize_t countBytesInFilter(const UInt8 * filt, size_t sz).std::chrono::steady_clockinstead ofsystem_clockin a few modulesMpp Version Check
TiFlash will check mpp-version in
FlashService::EstablishMPPConnection,FlashService::CancelMPPTask,FlashService::EstablishMPPConnection.if failed to check mpp-version is valid, tiflash will return grpc error
grpc::StatusCode::CANCELLEDwith message like:Hash Partition Writer
HashPartitionWriterV1with new codec patternHashPartitionWriterV1supports compression mode:TunnelSenderMode::LOCAL, must use method NONE.LZ4.ZSTD.NewMPPExchangeWriterwill generateHashPartitionWriterV1when exchange type istipb::ExchangeType::Hashand mpp-version of dag context is not 0.ExchangeReceiverBase<RPCContext>::decodeChunkswill check version ofmpp::MPPDataPacketGrafana
Add panel
Exchange Bytes/Secondsin GrafanaConfig
If
batch_send_min_limit_compressionLT 0, HashPartitionWriterV1 will use8192 * partition_num.Benchmark
Notice: in the master branch, #6713 will cause performance regression, try to resolve it and get benchmark below
Check List
Tests
Side effects
Documentation
Release note