Enable glibc-compatibility on arm by xzhangxian1008 · Pull Request #6572 · pingcap/tiflash

xzhangxian1008 · 2023-01-03T08:36:48Z

What problem does this PR solve?

Issue Number: close #6571

Problem Summary:

What is changed and how it works?

Check List

Tests

Unit test
Integration test
Manual test (add detailed scripts or steps below)
No code

Side effects

Performance regression: Consumes more CPU
Performance regression: Consumes more Memory
Breaking backward compatibility

Documentation

Release note

None

ti-chi-bot · 2023-01-03T08:36:50Z

[REVIEW NOTIFICATION]

This pull request has been approved by:

windtalker
ywqzzy

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

xzhangxian1008 · 2023-01-03T08:36:55Z

/hold

xzhangxian1008 · 2023-01-03T15:12:43Z

/run-all-tests

xzhangxian1008 · 2023-01-06T06:50:24Z

/cc @solotzg @windtalker

solotzg · 2023-01-11T10:03:45Z

Can you help to investigate whether we can remove this func safely ?

tiflash/libs/libglibc-compatibility/glibc-compatibility.c

Lines 27 to 30 in eaf1a4c

    
           size_t __pthread_get_minstack(const pthread_attr_t * attr) 
        
           { 
        
               return 1048576;        /// This is a guess. Don't sure it is correct. 
        
           }

xzhangxian1008 · 2023-01-11T11:40:38Z

Can you help to investigate whether we can remove this func safely ?

tiflash/libs/libglibc-compatibility/glibc-compatibility.c

Lines 27 to 30 in eaf1a4c

size_t __pthread_get_minstack(const pthread_attr_t * attr)

{

return 1048576; /// This is a guess. Don't sure it is correct.

}

okk, I will

xzhangxian1008 · 2023-01-20T07:00:35Z

Can you help to investigate whether we can remove this func safely ?

tiflash/libs/libglibc-compatibility/glibc-compatibility.c

Lines 27 to 30 in eaf1a4c

size_t __pthread_get_minstack(const pthread_attr_t * attr)

{

return 1048576; /// This is a guess. Don't sure it is correct.

}

I think we can not remove it before we manually designate the signal stack. However, the returned value could be changed to 16KiB, so that we can save many VSZ. Morever, though we can use SIGSTKSZ to define the size of signal stack, it's too small to collect enough information.

solotzg · 2023-01-29T02:36:08Z

libs/libglibc-compatibility/glibc-compatibility.c

 size_t __pthread_get_minstack(const pthread_attr_t * attr)
 {
-    return 1048576;        /// This is a guess. Don't sure it is correct.
+    return 16384;        /// This is a guess. Don't sure it is correct.


Please update comment and add explanation.

Please update comment and add explanation.

done

solotzg · 2023-01-29T02:50:31Z

lgtm

windtalker

LGTM

xzhangxian1008 · 2023-01-29T03:09:37Z

/unhold

xzhangxian1008 · 2023-01-29T03:10:06Z

/run-all-tests

xzhangxian1008 · 2023-01-30T08:17:42Z

/run-all-tests

windtalker · 2023-01-30T08:18:53Z

/merge

ti-chi-bot · 2023-01-30T08:18:54Z

@windtalker: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot · 2023-01-30T08:18:55Z

@windtalker: /merge in this pull request requires 2 approval(s).

Details

In response to this:

/merge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

windtalker

LGTM

windtalker · 2023-01-30T08:22:51Z

/merge

ti-chi-bot · 2023-01-30T08:22:52Z

@windtalker: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot · 2023-01-30T08:22:54Z

This pull request has been accepted and is ready to merge.

Details

Commit hash: 5b63cb7

LittleFall · 2023-01-30T08:22:55Z

/merge

ti-chi-bot · 2023-01-30T08:22:56Z

@LittleFall: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot · 2023-01-30T08:23:07Z

@xzhangxian1008: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

trigger some heavy tests which will not run always when PR updated.

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

xzhangxian1008 · 2023-01-30T09:01:01Z

/run-unit-test

close pingcap#6571 Signed-off-by: ywqzzy <592838129@qq.com>

wuhuizuo · 2024-11-01T06:53:52Z

/cherry-pick release-6.5

ti-chi-bot · 2024-11-01T06:54:30Z

@wuhuizuo: new pull request created to branch release-6.5: #9573.

Details

In response to this:

/cherry-pick release-6.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

xzhangxian1008 · 2024-11-01T07:52:10Z

/cherry-pick release-6.1

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>

ti-chi-bot · 2024-11-01T07:52:48Z

@xzhangxian1008: new pull request created to branch release-6.1: #9576.

Details

In response to this:

/cherry-pick release-6.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

close #6571 Co-authored-by: xzhangxian1008 <xzhangxian@foxmail.com>

close #6571 Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io> Co-authored-by: xzhangxian1008 <xzhangxian@foxmail.com>

xzhangxian1008 added 2 commits January 3, 2023 13:42

init

65b234d

remove useless codes

12f5b65

ti-chi-bot added the release-note-none Denotes a PR that doesn't merit a release note. label Jan 3, 2023

ti-chi-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Jan 3, 2023

fix duplicate symbol

567514e

ti-chi-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 4, 2023

xzhangxian1008 added 2 commits January 4, 2023 11:28

tweaking

17e22bc

Merge branch 'master' of ssh://github.com/pingcap/tiflash into arm

ae6edf9

ti-chi-bot requested review from solotzg and windtalker January 6, 2023 06:50

xzhangxian1008 added 2 commits January 16, 2023 16:59

Merge branch 'master' into arm

45a783b

change the min stack size

a5f9829

solotzg approved these changes Jan 29, 2023

View reviewed changes

windtalker approved these changes Jan 29, 2023

View reviewed changes

xzhangxian1008 added 2 commits January 29, 2023 11:05

add comment

d44243a

Merge branch 'master' of https://github.com/pingcap/tiflash into arm

a30303e

ti-chi-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 29, 2023

Merge branch 'master' into arm

c9ce2ac

ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jan 30, 2023

windtalker approved these changes Jan 30, 2023

View reviewed changes

ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jan 30, 2023

ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jan 30, 2023

Merge branch 'master' into arm

287230e

ti-chi-bot merged commit c5558c4 into pingcap:master Jan 30, 2023

xzhangxian1008 deleted the arm branch January 30, 2023 09:43

ywqzzy pushed a commit to ywqzzy/tiflash_1 that referenced this pull request Feb 13, 2023

Enable glibc-compatibility on arm (pingcap#6572)

b982a90

close pingcap#6571 Signed-off-by: ywqzzy <592838129@qq.com>

Lloyd-Pottiger mentioned this pull request Feb 20, 2023

Error starting tiflash on Ubuntu 22.04.2 LTS (Jammy Jellyfish) due to GLIBC version mismatch #6853

Closed

ti-chi-bot mentioned this pull request Nov 1, 2024

Enable glibc-compatibility on arm (#6572) #9573

Merged

12 tasks

ti-chi-bot pushed a commit to ti-chi-bot/tiflash that referenced this pull request Nov 1, 2024

This is an automated cherry-pick of pingcap#6572

c673059

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>

ti-chi-bot mentioned this pull request Nov 1, 2024

Enable glibc-compatibility on arm (#6572) #9576

Merged

12 tasks

ti-chi-bot bot pushed a commit that referenced this pull request Nov 4, 2024

Enable glibc-compatibility on arm (#6572) (#9573)

e9c2e2b

close #6571 Co-authored-by: xzhangxian1008 <xzhangxian@foxmail.com>

ti-chi-bot bot pushed a commit that referenced this pull request Nov 11, 2024

Enable glibc-compatibility on arm (#6572) (#9576)

1ab9ac6

close #6571 Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io> Co-authored-by: xzhangxian1008 <xzhangxian@foxmail.com>

Conversation

xzhangxian1008 commented Jan 3, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What problem does this PR solve?

What is changed and how it works?

Check List

Release note

Uh oh!

ti-chi-bot commented Jan 3, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

xzhangxian1008 commented Jan 3, 2023

Uh oh!

xzhangxian1008 commented Jan 3, 2023

Uh oh!

xzhangxian1008 commented Jan 6, 2023

Uh oh!

solotzg commented Jan 11, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

xzhangxian1008 commented Jan 11, 2023

Uh oh!

xzhangxian1008 commented Jan 20, 2023

Uh oh!

solotzg Jan 29, 2023

Choose a reason for hiding this comment

Uh oh!

xzhangxian1008 Jan 29, 2023

Choose a reason for hiding this comment

Uh oh!

solotzg commented Jan 29, 2023

Uh oh!

windtalker left a comment

Choose a reason for hiding this comment

Uh oh!

xzhangxian1008 commented Jan 29, 2023

Uh oh!

xzhangxian1008 commented Jan 29, 2023

Uh oh!

xzhangxian1008 commented Jan 30, 2023

Uh oh!

windtalker commented Jan 30, 2023

Uh oh!

ti-chi-bot commented Jan 30, 2023

Uh oh!

ti-chi-bot commented Jan 30, 2023

Uh oh!

windtalker left a comment

Choose a reason for hiding this comment

Uh oh!

windtalker commented Jan 30, 2023

Uh oh!

ti-chi-bot commented Jan 30, 2023

Uh oh!

ti-chi-bot commented Jan 30, 2023

Uh oh!

LittleFall commented Jan 30, 2023

Uh oh!

ti-chi-bot commented Jan 30, 2023

Uh oh!

ti-chi-bot commented Jan 30, 2023

Uh oh!

xzhangxian1008 commented Jan 30, 2023

Uh oh!

wuhuizuo commented Nov 1, 2024

Uh oh!

ti-chi-bot commented Nov 1, 2024

Uh oh!

xzhangxian1008 commented Nov 1, 2024

Uh oh!

ti-chi-bot commented Nov 1, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

xzhangxian1008 commented Jan 3, 2023 •

edited

Loading

ti-chi-bot commented Jan 3, 2023 •

edited

Loading

solotzg commented Jan 11, 2023 •

edited

Loading