Skip to content

fix the issue that decimal divide not round.#6471

Merged
ti-chi-bot merged 32 commits intomasterfrom
fix/decimal-divide-round
Feb 9, 2023
Merged

fix the issue that decimal divide not round.#6471
ti-chi-bot merged 32 commits intomasterfrom
fix/decimal-divide-round

Conversation

@LittleFall
Copy link
Contributor

@LittleFall LittleFall commented Dec 8, 2022 •
edited
Loading

What problem does this PR solve?

Issue Number: close #6393, close #6462, close #4488

Problem Summary: The result of decimal divide won't round at some precision.

What is changed and how it works?

add round logic

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

fix the issue that decimal divides not round in some precision.

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Dec 8, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • SeaRise
  • bestwoody

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/needs-linked-issue release-note-none Denotes a PR that doesn't merit a release note. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 8, 2022
@LittleFall LittleFall force-pushed the fix/decimal-divide-round branch from 3bab397 to f2f7654 Compare December 8, 2022 16:01
@ti-chi-bot ti-chi-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 8, 2022
@LittleFall LittleFall marked this pull request as draft December 8, 2022 16:01
@ti-chi-bot ti-chi-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. do-not-merge/needs-triage-completed and removed do-not-merge/needs-linked-issue labels Dec 8, 2022
@ti-chi-bot ti-chi-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed do-not-merge/needs-triage-completed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 12, 2022
@LittleFall LittleFall marked this pull request as ready for review December 12, 2022 13:26
@ti-chi-bot ti-chi-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 12, 2022
@LittleFall LittleFall changed the title Fix/decimal divide round fix the issue that decimal divide not round. Dec 12, 2022
@ti-chi-bot ti-chi-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. and removed release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/needs-triage-completed labels Dec 12, 2022
@LittleFall LittleFall removed the needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. label Dec 12, 2022
@ti-chi-bot ti-chi-bot added the needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. label Dec 12, 2022
@SeaRise SeaRise self-requested a review December 12, 2022 13:58
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Feb 9, 2023

This pull request has been accepted and is ready to merge.

DetailsCommit hash: 04012f1

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Feb 9, 2023
@ti-chi-bot ti-chi-bot removed the status/can-merge Indicates a PR has been approved by a committer. label Feb 9, 2023
@LittleFall
Copy link
Contributor Author

LittleFall commented Feb 9, 2023

/merge

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Feb 9, 2023

@LittleFall: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Feb 9, 2023

This pull request has been accepted and is ready to merge.

DetailsCommit hash: 153ea48

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Feb 9, 2023
@ti-chi-bot ti-chi-bot removed the status/can-merge Indicates a PR has been approved by a committer. label Feb 9, 2023
@LittleFall
Copy link
Contributor Author

LittleFall commented Feb 9, 2023

/merge

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Feb 9, 2023

@LittleFall: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Feb 9, 2023

This pull request has been accepted and is ready to merge.

DetailsCommit hash: f1a9064

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Feb 9, 2023
@ti-chi-bot ti-chi-bot merged commit 77c4d0f into master Feb 9, 2023
@ti-chi-bot ti-chi-bot mentioned this pull request Feb 9, 2023
Closed
12 tasks
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Feb 9, 2023

In response to a cherrypick label: new pull request created to branch release-6.1: #6794.

ti-chi-bot pushed a commit to ti-chi-bot/tiflash that referenced this pull request Feb 9, 2023
@LittleFall @ti-chi-bot
fix the issue that decimal divide not round. (pingcap#6471)
8fa8183 
close pingcap#4488, close pingcap#6393, close pingcap#6462
@ti-chi-bot ti-chi-bot mentioned this pull request Feb 9, 2023
Closed
12 tasks
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Feb 9, 2023

In response to a cherrypick label: new pull request created to branch release-6.5: #6795.

ti-chi-bot pushed a commit to ti-chi-bot/tiflash that referenced this pull request Feb 9, 2023
@LittleFall @ti-chi-bot
fix the issue that decimal divide not round. (pingcap#6471)
9470153 
close pingcap#4488, close pingcap#6393, close pingcap#6462
@LittleFall LittleFall deleted the fix/decimal-divide-round branch February 9, 2023 08:53
guo-shaoge pushed a commit to guo-shaoge/tiflash that referenced this pull request Feb 10, 2023
@LittleFall @guo-shaoge
fix the issue that decimal divide not round. (pingcap#6471)
206b807 
close pingcap#4488, close pingcap#6393, close pingcap#6462
@LittleFall LittleFall mentioned this pull request Mar 10, 2023
Merged
12 tasks
This was referenced Mar 10, 2023
Merged
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@windtalker windtalker Awaiting requested review from windtalker

@Lloyd-Pottiger Lloyd-Pottiger Awaiting requested review from Lloyd-Pottiger

2 more reviewers

@bestwoody bestwoody bestwoody approved these changes

@SeaRise SeaRise SeaRise approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.

Projects

None yet

Milestone

No milestone

7 participants

@LittleFall @ti-chi-bot @windtalker @SeaRise @Lloyd-Pottiger @bestwoody @wuhuizuo