Skip to content

Add metrics of Read Thread and Cache to Grafana#5476

Merged
JinheLin merged 2 commits intopingcap:masterfrom
JinheLin:update-grafana-json
Jul 27, 2022
Merged

Add metrics of Read Thread and Cache to Grafana#5476
JinheLin merged 2 commits intopingcap:masterfrom
JinheLin:update-grafana-json

Conversation

@JinheLin
Copy link
Contributor

@JinheLin JinheLin commented Jul 27, 2022

What problem does this PR solve?

Issue Number: close #5475

What is changed and how it works?

KV6tiuuaXV
o4J7GrQSdj
image

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jul 27, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • Lloyd-Pottiger
  • flowbehappy

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/needs-triage-completed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 27, 2022
@JinheLin JinheLin self-assigned this Jul 27, 2022
@flowbehappy flowbehappy self-requested a review July 27, 2022 09:09
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 27, 2022
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jul 27, 2022
@Lloyd-Pottiger
Copy link
Contributor

Lloyd-Pottiger commented Jul 27, 2022

/merge

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jul 27, 2022

@Lloyd-Pottiger: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jul 27, 2022

This pull request has been accepted and is ready to merge.

DetailsCommit hash: b40dd1d

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jul 27, 2022
@flowbehappy
Copy link
Contributor

flowbehappy commented Jul 27, 2022

/merge

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jul 27, 2022

@flowbehappy: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@JinheLin
Copy link
Contributor Author

JinheLin commented Jul 27, 2022

/merge

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jul 27, 2022

@JinheLin: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@sre-bot
Copy link
Collaborator

sre-bot commented Jul 27, 2022

Coverage for changed files

no c/c++ source change detected

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
18834      9435             49.90%    214752  95347        55.60%

full coverage report (for internal network access only)

@JinheLin JinheLin merged commit 72f7481 into pingcap:master Jul 27, 2022
@ti-chi-bot ti-chi-bot mentioned this pull request Jul 27, 2022
Merged
12 tasks
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jul 27, 2022

In response to a cherrypick label: new pull request created: #5481.

ti-chi-bot added a commit that referenced this pull request Jul 27, 2022
@ti-chi-bot
Add metrics of Read Thread and Cache to Grafana (#5476) (#5481)
a0cd4f6 
close #5475
@JinheLin JinheLin deleted the update-grafana-json branch August 4, 2022 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@flowbehappy flowbehappy flowbehappy approved these changes

@Lloyd-Pottiger Lloyd-Pottiger Lloyd-Pottiger approved these changes

@JaySon-Huang JaySon-Huang Awaiting requested review from JaySon-Huang

Assignees

@JinheLin JinheLin

Labels

needs-cherry-pick-release-6.2 release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Metrics of read thread pool needs to be added to Grafana

5 participants

@JinheLin @ti-chi-bot @Lloyd-Pottiger @flowbehappy @sre-bot