Skip to content

refine Window Executor Test#5464

Merged
ti-chi-bot merged 4 commits intopingcap:masterfrom
SeaRise:fine_window_tests
Jul 27, 2022
Merged

refine Window Executor Test#5464
ti-chi-bot merged 4 commits intopingcap:masterfrom
SeaRise:fine_window_tests

Conversation

@SeaRise
Copy link
Contributor

@SeaRise SeaRise commented Jul 25, 2022 •
edited
Loading

What problem does this PR solve?

Issue Number: close #5465 ref #4609

Problem Summary:

What is changed and how it works?

  • move WindowExecutorTest from dbms/src/WindowFunctions/tests to dbms/src/Flash/tests/
  • add test cases that executing window function concurrently.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jul 25, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • mengxin9014
  • ywqzzy

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/needs-linked-issue release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed do-not-merge/needs-linked-issue labels Jul 25, 2022
@SeaRise
Copy link
Contributor Author

SeaRise commented Jul 25, 2022

/run-unit-test

@SeaRise SeaRise requested review from mengxin9014 and ywqzzy July 25, 2022 11:05
@sre-bot
Copy link
Collaborator

sre-bot commented Jul 25, 2022

Coverage for changed files

Filename                                                                                                      Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
/home/jenkins/agent/workspace/tiflash-build-common/tiflash/dbms/src/Flash/tests/gtest_window_executor.cpp         108                31    71.30%           4                 0   100.00%         150                 0   100.00%          32                16    50.00%
-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                                                                                                             108                31    71.30%           4                 0   100.00%         150                 0   100.00%          32                16    50.00%

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
18801      9450             49.74%    214203  95472        55.43%

full coverage report (for internal network access only)

@SeaRise SeaRise mentioned this pull request Jul 25, 2022
Merged
12 tasks
SeaRise added a commit to SeaRise/tiflash that referenced this pull request Jul 25, 2022
@SeaRise
port from pingcap#5464
68eccd7
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 26, 2022
mengxin9014
mengxin9014 approved these changes Jul 27, 2022
View reviewed changes
Copy link
Contributor

@mengxin9014 mengxin9014 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jul 27, 2022
@SeaRise
Copy link
Contributor Author

SeaRise commented Jul 27, 2022

/merge

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jul 27, 2022

@SeaRise: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jul 27, 2022

This pull request has been accepted and is ready to merge.

DetailsCommit hash: 23bc937

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jul 27, 2022
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jul 27, 2022

@SeaRise: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@SeaRise
Copy link
Contributor Author

SeaRise commented Jul 27, 2022

/rebuild

@SeaRise
Copy link
Contributor Author

SeaRise commented Jul 27, 2022

/run-integration-test

@sre-bot
Copy link
Collaborator

sre-bot commented Jul 27, 2022

Coverage for changed files

Filename                                                                                                      Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
/home/jenkins/agent/workspace/tiflash-build-common/tiflash/dbms/src/Flash/tests/gtest_window_executor.cpp         108                31    71.30%           4                 0   100.00%         150                 0   100.00%          32                16    50.00%
-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                                                                                                             108                31    71.30%           4                 0   100.00%         150                 0   100.00%          32                16    50.00%

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
18834      9439             49.88%    214752  95457        55.55%

full coverage report (for internal network access only)

@ti-chi-bot ti-chi-bot merged commit ee2f753 into pingcap:master Jul 27, 2022
@SeaRise SeaRise deleted the fine_window_tests branch July 27, 2022 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@mengxin9014 mengxin9014 mengxin9014 approved these changes

@ywqzzy ywqzzy ywqzzy approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Test concurrent execution for window function

5 participants

@SeaRise @ti-chi-bot @sre-bot @mengxin9014 @ywqzzy