Skip to content

Fix extract fullstack test#5420

Merged
ti-chi-bot merged 1 commit intopingcap:masterfrom
zanmato1984:fix-extract-fullstack-test
Jul 20, 2022
Merged

Fix extract fullstack test#5420
ti-chi-bot merged 1 commit intopingcap:masterfrom
zanmato1984:fix-extract-fullstack-test

Conversation

@zanmato1984
Copy link
Contributor

@zanmato1984 zanmato1984 commented Jul 20, 2022 •
edited
Loading

What problem does this PR solve?

Issue Number: close #5421

Problem Summary:

After TiDB PR pingcap/tidb#36297, extract(day_microsecond/second/minute/hour) behavior changed to evaluate the second argument to time, thus the day portion wouldn't be showing up in the result.

What is changed and how it works?

Update test reference.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jul 20, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • windtalker
  • yibin87

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/needs-linked-issue release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. do-not-merge/needs-triage-completed and removed do-not-merge/needs-linked-issue labels Jul 20, 2022
@zanmato1984
Copy link
Contributor Author

zanmato1984 commented Jul 20, 2022

/check-issue-triage-complete

@zanmato1984
Copy link
Contributor Author

zanmato1984 commented Jul 20, 2022

/run-check-issue-triage-complete

@zanmato1984
Copy link
Contributor Author

zanmato1984 commented Jul 20, 2022

/rebuild

yibin87
yibin87 approved these changes Jul 20, 2022
View reviewed changes
Copy link
Contributor

@yibin87 yibin87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 20, 2022
windtalker
windtalker approved these changes Jul 20, 2022
View reviewed changes
Copy link
Contributor

@windtalker windtalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jul 20, 2022
@zanmato1984
Copy link
Contributor Author

zanmato1984 commented Jul 20, 2022

/merge

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jul 20, 2022

@zanmato1984: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jul 20, 2022

This pull request has been accepted and is ready to merge.

DetailsCommit hash: a5fe1f6

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jul 20, 2022
@sre-bot
Copy link
Collaborator

sre-bot commented Jul 20, 2022

Coverage for changed files

no c/c++ source change detected

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
18625      9393             49.57%    212350  94899        55.31%

full coverage report (for internal network access only)

@ti-chi-bot ti-chi-bot merged commit 4abef77 into pingcap:master Jul 20, 2022
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jul 20, 2022

In response to a cherrypick label: cannot checkout release-6.2: error checking out release-6.2: exit status 1. output: error: pathspec 'release-6.2' did not match any file(s) known to git

@zanmato1984 zanmato1984 deleted the fix-extract-fullstack-test branch July 20, 2022 03:39
zanmato1984 added a commit to zanmato1984/tiflash that referenced this pull request Jul 20, 2022
@zanmato1984
Revert "Fix extract fullstack test (pingcap#5420)"
fcd6322 
This reverts commit 4abef77.
@zanmato1984 zanmato1984 mentioned this pull request Jul 20, 2022
Merged
12 tasks
ti-chi-bot pushed a commit that referenced this pull request Jul 21, 2022
@zanmato1984
Revert "Fix extract fullstack test (#5420)" (#5427)
0cb0172 
close #5421
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@windtalker windtalker windtalker approved these changes

@yibin87 yibin87 yibin87 approved these changes

Assignees

No one assigned

Labels

affects-6.2 needs-cherry-pick-release-6.2 release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Fullstack extract datetime is broken

5 participants

@zanmato1984 @ti-chi-bot @sre-bot @windtalker @yibin87