Skip to content

fix the incorrect execution time of join in explain analyze#5411

Merged
ti-chi-bot merged 2 commits intopingcap:masterfrom
SeaRise:fix_join_explain_analyze
Jul 20, 2022
Merged

fix the incorrect execution time of join in explain analyze#5411
ti-chi-bot merged 2 commits intopingcap:masterfrom
SeaRise:fix_join_explain_analyze

Conversation

@SeaRise
Copy link
Contributor

@SeaRise SeaRise commented Jul 19, 2022 •
edited
Loading

What problem does this PR solve?

Issue Number: close #5412

Problem Summary:

What is changed and how it works?

  • Add the execution time of HashJoinBuildBlockInputStream instead of streams of build_side_root_executor_id in DAGReponseWriter::addExecuteSummaries
  • Add join_build_info in mpp_task_tracing

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Fix the incorrect execution time of join in explain analyze.

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jul 19, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • windtalker
  • ywqzzy

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/needs-linked-issue release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 19, 2022
@SeaRise
Copy link
Contributor Author

SeaRise commented Jul 19, 2022

/run-all-tests

@SeaRise SeaRise changed the title fix the incorrect execution time of join in analyze fix the incorrect execution time of join in explain analyze Jul 19, 2022
@SeaRise
Copy link
Contributor Author

SeaRise commented Jul 19, 2022

434690946278883329 dot

@SeaRise
Copy link
Contributor Author

SeaRise commented Jul 19, 2022

/run-integration-test

@sre-bot
Copy link
Collaborator

sre-bot commented Jul 19, 2022

Coverage for changed files

Filename                                     Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
Coprocessor/DAGContext.h                          41                14    65.85%          32                12    62.50%          91                34    62.64%          12                 6    50.00%
Coprocessor/DAGQueryBlockInterpreter.cpp         255                85    66.67%          33                 5    84.85%         601               139    76.87%         162                56    65.43%
Coprocessor/DAGResponseWriter.cpp                 71                62    12.68%           5                 3    40.00%         171               159     7.02%          68                64     5.88%
Statistics/ExecutorStatistics.h                   17                17     0.00%           8                 8     0.00%          63                63     0.00%           6                 6     0.00%
Statistics/JoinImpl.cpp                           11                11     0.00%           3                 3     0.00%          43                43     0.00%          10                10     0.00%
Statistics/JoinImpl.h                              1                 1     0.00%           1                 1     0.00%           3                 3     0.00%           0                 0         -
--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                                            396               190    52.02%          82                32    60.98%         972               441    54.63%         258               142    44.96%

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
18594      9573             48.52%    211811  96352        54.51%

full coverage report (for internal network access only)

@SeaRise
Copy link
Contributor Author

SeaRise commented Jul 19, 2022

/run-integration-test

@SeaRise SeaRise requested review from windtalker and ywqzzy July 19, 2022 10:26
ywqzzy
ywqzzy approved these changes Jul 20, 2022
View reviewed changes
Copy link
Contributor

@ywqzzy ywqzzy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 20, 2022
windtalker
windtalker reviewed Jul 20, 2022
View reviewed changes
windtalker
windtalker approved these changes Jul 20, 2022
View reviewed changes
Copy link
Contributor

@windtalker windtalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jul 20, 2022
@windtalker
Copy link
Contributor

windtalker commented Jul 20, 2022

/merge

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jul 20, 2022

@windtalker: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jul 20, 2022

This pull request has been accepted and is ready to merge.

DetailsCommit hash: 1c5b5f0

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jul 20, 2022
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jul 20, 2022

@SeaRise: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@sre-bot
Copy link
Collaborator

sre-bot commented Jul 20, 2022

Coverage for changed files

Filename                                     Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
Coprocessor/DAGContext.h                          41                14    65.85%          32                12    62.50%          91                34    62.64%          12                 6    50.00%
Coprocessor/DAGQueryBlockInterpreter.cpp         255                83    67.45%          33                 5    84.85%         601               134    77.70%         162                54    66.67%
Coprocessor/DAGResponseWriter.cpp                 71                62    12.68%           5                 3    40.00%         171               159     7.02%          68                64     5.88%
Statistics/ExecutorStatistics.h                   17                17     0.00%           8                 8     0.00%          63                63     0.00%           6                 6     0.00%
Statistics/JoinImpl.cpp                           11                11     0.00%           3                 3     0.00%          43                43     0.00%          10                10     0.00%
Statistics/JoinImpl.h                              1                 1     0.00%           1                 1     0.00%           3                 3     0.00%           0                 0         -
--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                                            396               188    52.53%          82                32    60.98%         972               436    55.14%         258               140    45.74%

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
18625      9391             49.58%    212364  94854        55.33%

full coverage report (for internal network access only)

@ti-chi-bot ti-chi-bot merged commit cecbe66 into pingcap:master Jul 20, 2022
@SeaRise SeaRise deleted the fix_join_explain_analyze branch July 20, 2022 07:10
@SeaRise SeaRise mentioned this pull request Jul 25, 2022
Merged
12 tasks
SeaRise added a commit to SeaRise/tiflash that referenced this pull request Jul 25, 2022
@SeaRise
port change from pingcap#5411
ca71b3b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@windtalker windtalker windtalker approved these changes

+1 more reviewer

@ywqzzy ywqzzy ywqzzy approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

The execution time of join in explain analyze is not correct

5 participants

@SeaRise @ti-chi-bot @sre-bot @windtalker @ywqzzy