ignore delmark when add minmax for pk column#4746
Merged
ti-chi-bot merged 3 commits intopingcap:masterfrom Apr 25, 2022
Merged
Conversation
Member
|
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. DetailsReviewer can indicate their review by submitting an approval review. |
39127b9 to
85b237c
Compare
Contributor
Author
|
/run-all-tests |
Collaborator
Coverage for changed filesCoverage summaryfull coverage report (for internal network access only) |
flowbehappy
approved these changes
Apr 25, 2022
ti-chi-bot
pushed a commit
to ti-chi-bot/tiflash
that referenced
this pull request
Apr 25, 2022
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
12 tasks
Member
|
In response to a cherrypick label: new pull request created: #4756. |
ti-chi-bot
pushed a commit
to ti-chi-bot/tiflash
that referenced
this pull request
Apr 25, 2022
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
12 tasks
Member
|
In response to a cherrypick label: new pull request created: #4757. |
ti-chi-bot
pushed a commit
to ti-chi-bot/tiflash
that referenced
this pull request
Apr 25, 2022
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
12 tasks
Member
|
In response to a cherrypick label: new pull request created: #4758. |
12 tasks
Member
|
In response to a cherrypick label: new pull request created: #4759. |
12 tasks
Member
|
In response to a cherrypick label: new pull request created: #4760. |
12 tasks
Member
|
In response to a cherrypick label: new pull request created: #4761. |
lidezhu
added a commit
that referenced
this pull request
Apr 26, 2022
lidezhu
added a commit
to lidezhu/tics
that referenced
this pull request
May 23, 2022
lidezhu
added a commit
to lidezhu/tics
that referenced
this pull request
May 23, 2022
lidezhu
added a commit
that referenced
this pull request
May 23, 2022
lidezhu
added a commit
to lidezhu/tics
that referenced
this pull request
May 31, 2022
lidezhu
added a commit
to lidezhu/tics
that referenced
this pull request
May 31, 2022
…4963) * ignore delmark when add minmax for pk column (pingcap#4746) close pingcap#4747 * fix static analysis * use release-5.4 branch image for other components * fix fullstack image
ti-chi-bot
added a commit
that referenced
this pull request
Jun 4, 2022
12 tasks
ti-chi-bot
added a commit
that referenced
this pull request
Jun 21, 2022
ti-chi-bot
added a commit
that referenced
this pull request
Jun 21, 2022
ti-chi-bot
added a commit
that referenced
this pull request
Jun 21, 2022
lidezhu
pushed a commit
to lidezhu/tics
that referenced
this pull request
Aug 29, 2022
breezewish
pushed a commit
that referenced
this pull request
Aug 29, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #4747
Problem Summary:
If rows in a stable pack is all mark deleted, then it's minmax index for pk column is both 0.
And when
dt_enable_skippable_placeis enabled and try to place delta index on this segment, it will filter out all pack which is not in the pk range [start_key, +infinite). So the previous stable pack is ignored.But for the place delta index algorithm, it's expected that all the rows in the pk range [start_key, +infinite) is placed no matter whether it's deleted. So when we try to read this segment using the placed delta index, it reports error like "DeltaMerge return wrong result"
What is changed and how it works?
Ignore delmark when add minmax for pk column.
Check List
Tests
Side effects
Documentation
Release note