Fix broken ut SegmentDeletionRelevantPlaceTest#4607
Merged
ti-chi-bot merged 9 commits intopingcap:masterfrom Jun 6, 2022
Merged
Fix broken ut SegmentDeletionRelevantPlaceTest#4607ti-chi-bot merged 9 commits intopingcap:masterfrom
ti-chi-bot merged 9 commits intopingcap:masterfrom
Conversation
Member
|
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. DetailsReviewer can indicate their review by submitting an approval review. |
7baf4c7 to
8f99e7f
Compare
8f99e7f to
229ac0f
Compare
Contributor
Author
|
/run-all-tests |
7cf8c1a to
8330204
Compare
Contributor
Author
|
/run-all-tests |
JaySon-Huang
commented
Jun 1, 2022
Signed-off-by: JaySon-Huang <jayson.hjs@gmail.com>
fbbe076 to
35a8c2e
Compare
JaySon-Huang
commented
Jun 1, 2022
Comment on lines
-428
to
-438
| DB::Settings getSettings() | ||
| { | ||
| DB::Settings settings; | ||
| auto enable_relevant_place = GetParam(); | ||
|
|
||
| if (enable_relevant_place) | ||
| settings.set("dt_enable_relevant_place", "1"); | ||
| else | ||
| settings.set("dt_enable_relevant_place", "0"); | ||
| return settings; | ||
| } |
Contributor
Author
There was a problem hiding this comment.
This is a useless function that never called after #2415
Contributor
Author
|
/run-all-tests |
Collaborator
Coverage for changed filesCoverage summaryfull coverage report (for internal network access only) |
lidezhu
reviewed
Jun 4, 2022
lidezhu
approved these changes
Jun 4, 2022
Contributor
lidezhu
left a comment
There was a problem hiding this comment.
LGTM with minor comments
Co-authored-by: lidezhu <47731263+lidezhu@users.noreply.github.com>
Signed-off-by: JaySon-Huang <jayson.hjs@gmail.com>
Contributor
Author
|
/run-all-tests |
Collaborator
Coverage for changed filesCoverage summaryfull coverage report (for internal network access only) |
flowbehappy
approved these changes
Jun 6, 2022
Contributor
Author
|
/merge |
Member
|
@JaySon-Huang: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests You only need to trigger If you have any questions about the PR merge process, please refer to pr process. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
Member
|
This pull request has been accepted and is ready to merge. DetailsCommit hash: 2085bd6 |
Collaborator
Coverage for changed filesCoverage summaryfull coverage report (for internal network access only) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #4606
Problem Summary:
After #2415
SegmentDeletionRelevantPlaceTest::getSettingsis not used at all, "SegmentDeletionRelevantPlaceTest" only run test with relevant_place with default value.What is changed and how it works?
relevant_placesettings byreloadCheck List
Tests
Side effects
Documentation
Release note