FIX segment ut using same tmp dir#2415
Merged
ti-srebot merged 10 commits intopingcap:masterfrom Jul 20, 2021
jiaqizho:fix-segment-ut
Merged
FIX segment ut using same tmp dir#2415ti-srebot merged 10 commits intopingcap:masterfrom jiaqizho:fix-segment-ut
ti-srebot merged 10 commits intopingcap:masterfrom
jiaqizho:fix-segment-ut
Conversation
Signed-off-by: jiaqizho <zhoujiaqi@pingcap.com>
Signed-off-by: jiaqizho <zhoujiaqi@pingcap.com>
Signed-off-by: jiaqizho <zhoujiaqi@pingcap.com>
Signed-off-by: jiaqizho <zhoujiaqi@pingcap.com>
SchrodingerZhu
approved these changes
Jul 19, 2021
Contributor
SchrodingerZhu
left a comment
There was a problem hiding this comment.
LGTM. but This PR can also remove the extra checks in the GC routine and replace it with an assertion? cc @JaySon-Huang
Contributor
Author
|
/run-all-tests |
Contributor
|
/rebuild |
dbms/src/Storages/Page/tests/gtest_page_storage_multi_paths.cpp
Outdated
Show resolved
Hide resolved
Contributor
Author
|
/run-all-tests |
Contributor
|
/merge |
Collaborator
|
/run-all-tests |
12 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: jiaqizho zhoujiaqi@pingcap.com
What problem does this PR solve?
Issue Number: close #2393
Problem Summary:
What is changed and how it works?
Proposal: split segment test case in different tmp dir, and cleanup after env down.
What's Changed:
Related changes
None
Check List
Tests
Side effects
Release note