Tracing: Add read_tso as tracing id to PageStorage snapshot#4288
Merged
ti-chi-bot merged 10 commits intopingcap:masterfrom Apr 8, 2022
Merged
Tracing: Add read_tso as tracing id to PageStorage snapshot#4288ti-chi-bot merged 10 commits intopingcap:masterfrom
ti-chi-bot merged 10 commits intopingcap:masterfrom
Conversation
Member
|
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. DetailsReviewer can indicate their review by submitting an approval review. |
JaySon-Huang
commented
Mar 15, 2022
c55bd88 to
8677520
Compare
Contributor
Author
|
/run-all-tests |
1 similar comment
Contributor
Author
|
/run-all-tests |
947eef9 to
0d0b79d
Compare
Contributor
Author
|
/rebuild |
Contributor
Author
|
/run-all-tests |
fuzhe1989
reviewed
Mar 16, 2022
SeaRise
reviewed
Mar 16, 2022
5a2dfc9 to
56ffca8
Compare
Contributor
Author
|
/hold |
56ffca8 to
cb3fedf
Compare
Contributor
Author
|
base_4w.log.zip after this PR, here are two logging files that contain queries that scan 40,000/500,000,000 rows from the storage layer. PTAL for this PR @fuzhe1989 @SeaRise @lidezhu |
Contributor
Author
|
/run-all-tests |
Contributor
Author
|
/run-unit-test |
Collaborator
Coverage for changed filesCoverage summaryfull coverage report (for internal network access only) |
SeaRise
reviewed
Apr 7, 2022
c79c4a6 to
ed9de1a
Compare
SeaRise
approved these changes
Apr 7, 2022
Contributor
Author
|
/merge |
Member
|
@JaySon-Huang: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests You only need to trigger If you have any questions about the PR merge process, please refer to pr process. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
Member
|
This pull request has been accepted and is ready to merge. DetailsCommit hash: eefc658 |
Collaborator
Coverage for changed filesCoverage summaryfull coverage report (for internal network access only) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #4287
Problem Summary:
After #3632, we introduce DynamicThreadPool to reuse threads for handling incoming tasks. Then the "thread_id" record in PageStorage snapshot become less useful.
Add a "tracing_id" to the PageStorage snapshot, and use "read_tso" as the "tracing_id", it is more useful for locating bugs.
What is changed and how it works?
DB::Loggerto avoid lock confilct inPoco::Logger::getread_tsoastracing_idCheck List
Tests
Side effects
Documentation
Release note