Skip to content

Introduce DynamicThreadPool#3632

Merged
ti-chi-bot merged 36 commits intopingcap:masterfrom
fuzhe1989:fuzhe/dynamic_thread_pool
Dec 28, 2021
Merged

Introduce DynamicThreadPool#3632
ti-chi-bot merged 36 commits intopingcap:masterfrom
fuzhe1989:fuzhe/dynamic_thread_pool

Conversation

@fuzhe1989
Copy link
Contributor

@fuzhe1989 fuzhe1989 commented Dec 10, 2021 •
edited by mengxin9014
Loading

What problem does this PR solve?

Issue Number: close #xxx

Problem Summary:

What is changed and how it works?

Introduce DynamicThreadPool which is a simple thread pool with automatic expanding and shrinking.

Features:

  1. Guarantee one thread per task so that no deadlock will happen due to tasks wait for each other.
  2. Automatically expanding by allocating dynamic threads when no free threads avaliable.
  3. Automatically shrinking by let cold threads exit. There's no extra background thread for shrinking.
  4. Reuse dynamic threads in LIFO to enable some threads gradually cooling.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Dec 10, 2021 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • bestwoody

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Dec 10, 2021
@ti-chi-bot ti-chi-bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Dec 10, 2021
@fuzhe1989
Copy link
Contributor Author

fuzhe1989 commented Dec 10, 2021

/run-unit-test

@sre-bot
Copy link
Collaborator

sre-bot commented Dec 10, 2021

Coverage detail: https://ci-internal.pingcap.net/job/tics_ghpr_unit_test/331/cobertura/
(Coverage detail url is limited office network access)

lines: 42.1% (46586 out of 110778)
branches: 5.8% (69837 out of 1202057)

@fuzhe1989 fuzhe1989 changed the title [DNM] Introduce DynamicThreadPool Introduce DynamicThreadPool Dec 10, 2021
@fuzhe1989
Copy link
Contributor Author

fuzhe1989 commented Dec 10, 2021

TODO: need more unittests.

riteme
riteme reviewed Dec 16, 2021
View reviewed changes
@fuzhe1989
Copy link
Contributor Author

fuzhe1989 commented Dec 23, 2021

Promise to add enough unittests before merge.

bestwoody
bestwoody reviewed Dec 27, 2021
View reviewed changes
bestwoody
bestwoody reviewed Dec 27, 2021
View reviewed changes
windtalker
windtalker approved these changes Dec 28, 2021
View reviewed changes
Copy link
Contributor

@windtalker windtalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fuzhe1989
Copy link
Contributor Author

fuzhe1989 commented Dec 28, 2021

/merge

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Dec 28, 2021

@fuzhe1989: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Dec 28, 2021

This pull request has been accepted and is ready to merge.

DetailsCommit hash: 1f82df4

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Dec 28, 2021
@ti-chi-bot ti-chi-bot removed the status/can-merge Indicates a PR has been approved by a committer. label Dec 28, 2021
@fuzhe1989
Copy link
Contributor Author

fuzhe1989 commented Dec 28, 2021

/merge

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Dec 28, 2021

@fuzhe1989: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Dec 28, 2021

This pull request has been accepted and is ready to merge.

DetailsCommit hash: adc4df9

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Dec 28, 2021
@ti-chi-bot ti-chi-bot removed the status/can-merge Indicates a PR has been approved by a committer. label Dec 28, 2021
@fuzhe1989
Copy link
Contributor Author

fuzhe1989 commented Dec 28, 2021

/merge

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Dec 28, 2021

@fuzhe1989: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Dec 28, 2021

This pull request has been accepted and is ready to merge.

DetailsCommit hash: c879bbb

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Dec 28, 2021
@fuzhe1989
Copy link
Contributor Author

fuzhe1989 commented Dec 28, 2021

/rebuild

@sre-bot
Copy link
Collaborator

sre-bot commented Dec 28, 2021

Coverage detail: https://ci-internal.pingcap.net/job/tics_ghpr_unit_test/697/cobertura/
(Coverage detail url is limited office network access)

lines: 43.2% (48858 out of 113186)
branches: 6.3% (76074 out of 1216385)

@ti-chi-bot ti-chi-bot merged commit 0e6d5f1 into pingcap:master Dec 28, 2021
@fuzhe1989 fuzhe1989 deleted the fuzhe/dynamic_thread_pool branch December 28, 2021 10:41
@sre-bot
Copy link
Collaborator

sre-bot commented Feb 17, 2022

Coverage detail: https://ci-internal.pingcap.net/job/tics_ghpr_unit_test/1567/cobertura/
(Coverage detail url is limited office network access)

lines: 43.2% (48853 out of 113186)
branches: 6.3% (76066 out of 1216385)

This was referenced Mar 15, 2022
Closed
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@windtalker windtalker windtalker approved these changes

+2 more reviewers

@riteme riteme riteme left review comments

@bestwoody bestwoody bestwoody approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@fuzhe1989 @ti-chi-bot @sre-bot @bestwoody @windtalker @riteme