Skip to content

Clean deprecated directories and internal links#4278

Merged
ti-chi-bot merged 6 commits intopingcap:masterfrom
solotzg:clean-dir
Mar 15, 2022
Merged

Clean deprecated directories and internal links#4278
ti-chi-bot merged 6 commits intopingcap:masterfrom
solotzg:clean-dir

Conversation

@solotzg
Copy link
Contributor

@solotzg solotzg commented Mar 15, 2022 •
edited
Loading

Signed-off-by: Zhigao Tong tongzhigao@pingcap.com

What problem does this PR solve?

Issue Number: close #4141

Problem Summary:

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Mar 15, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • SchrodingerZhu
  • zanmato1984

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Mar 15, 2022
@solotzg
Copy link
Contributor Author

solotzg commented Mar 15, 2022

/rebuild

zanmato1984
zanmato1984 approved these changes Mar 15, 2022
View reviewed changes
Copy link
Contributor

@zanmato1984 zanmato1984 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LVGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 15, 2022
@solotzg
Copy link
Contributor Author

solotzg commented Mar 15, 2022

/rebuild

@solotzg solotzg changed the title clean deprecated directories clean deprecated directories and internal links Mar 15, 2022
@solotzg solotzg changed the title clean deprecated directories and internal links Clean deprecated directories and internal links Mar 15, 2022
solotzg added 3 commits March 15, 2022 17:24
@solotzg
clean deprecated directories
1d000a2 
Signed-off-by: Zhigao Tong <tongzhigao@pingcap.com>
@solotzg
fix
ff00062 
Signed-off-by: Zhigao Tong <tongzhigao@pingcap.com>
@solotzg
1
18cce70 
Signed-off-by: Zhigao Tong <tongzhigao@pingcap.com>
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Mar 15, 2022
@solotzg
Copy link
Contributor Author

solotzg commented Mar 15, 2022

/rebuild

@solotzg
fix
e4eeffe 
Signed-off-by: Zhigao Tong <tongzhigao@pingcap.com>
@solotzg
Copy link
Contributor Author

solotzg commented Mar 15, 2022

/rebuild

@solotzg
Copy link
Contributor Author

solotzg commented Mar 15, 2022

/run-all-tests

@solotzg
Copy link
Contributor Author

solotzg commented Mar 15, 2022

/merge

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Mar 15, 2022

@solotzg: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Mar 15, 2022

This pull request has been accepted and is ready to merge.

DetailsCommit hash: e4eeffe

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 15, 2022
@solotzg
Copy link
Contributor Author

solotzg commented Mar 15, 2022

/merge

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Mar 15, 2022

@solotzg: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@sre-bot
Copy link
Collaborator

sre-bot commented Mar 15, 2022

Coverage for changed files

too many lines from llvm-cov, please refer to full report instead

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
16923      9503             43.85%    190677  96474        49.40%

full coverage report (for internal network access only)

@sre-bot
Copy link
Collaborator

sre-bot commented Mar 15, 2022

Coverage for changed files

too many lines from llvm-cov, please refer to full report instead

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
16923      9503             43.85%    190675  96487        49.40%

full coverage report (for internal network access only)

@ti-chi-bot ti-chi-bot merged commit ee45816 into pingcap:master Mar 15, 2022
@solotzg solotzg deleted the clean-dir branch March 15, 2022 13:52
@sre-bot
Copy link
Collaborator

sre-bot commented Mar 15, 2022

Coverage for changed files

too many lines from llvm-cov, please refer to full report instead

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
16923      9503             43.85%    190675  96462        49.41%

full coverage report (for internal network access only)

JaySon-Huang pushed a commit to JaySon-Huang/tiflash that referenced this pull request Mar 17, 2022
@solotzg @JaySon-Huang
Clean deprecated directories and internal links (pingcap#4278)
4a16fac 
ref pingcap#4141
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zanmato1984 zanmato1984 zanmato1984 approved these changes

+1 more reviewer

@SchrodingerZhu SchrodingerZhu SchrodingerZhu approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Refine CI process & Clean internal service links

5 participants

@solotzg @ti-chi-bot @sre-bot @zanmato1984 @SchrodingerZhu