Skip to content

MPP: update the state of building a hash table when createOnce throw exceptions (#4202)#4268

Merged
ti-chi-bot merged 29 commits intopingcap:release-5.2from
ti-chi-bot:cherry-pick-4202-to-release-5.2
Apr 14, 2022
Merged

MPP: update the state of building a hash table when createOnce throw exceptions (#4202)#4268
ti-chi-bot merged 29 commits intopingcap:release-5.2from
ti-chi-bot:cherry-pick-4202-to-release-5.2

Conversation

@ti-chi-bot
Copy link
Member

@ti-chi-bot ti-chi-bot commented Mar 14, 2022 •
edited by JaySon-Huang
Loading

This is an automated cherry-pick of #4202

Signed-off-by: fzhedu fzhedu@gmail.com

What problem does this PR solve?

Issue Number: close #4195
Problem Summary:
set FinishBuild be true when createOnce throw exceptions

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Fix the issue that a query containing `JOIN` could be hung if an error was encountered

@fzhedu @ti-chi-bot
This is an automated cherry-pick of pingcap#4202
b630775 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member Author

ti-chi-bot commented Mar 14, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • fzhedu
  • windtalker

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/cherry-pick-not-approved labels Mar 14, 2022
@ti-chi-bot ti-chi-bot mentioned this pull request Mar 14, 2022
Merged
12 tasks
@ti-chi-bot ti-chi-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/bugfix This PR fixes a bug. type/cherry-pick-for-release-5.2 labels Mar 14, 2022
@ti-chi-bot ti-chi-bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 14, 2022
@CLAassistant
Copy link

CLAassistant commented Apr 1, 2022 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLAassistant commented Apr 1, 2022

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@VelocityLight VelocityLight added cherry-pick-approved Cherry pick PR approved by release team. do-not-merge/cherry-pick-not-approved and removed do-not-merge/cherry-pick-not-approved cherry-pick-approved Cherry pick PR approved by release team. labels Apr 10, 2022
@fzhedu
Copy link
Contributor

fzhedu commented Apr 14, 2022

/merge

@ti-chi-bot
Copy link
Member Author

ti-chi-bot commented Apr 14, 2022

@fzhedu: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@fzhedu
Copy link
Contributor

fzhedu commented Apr 14, 2022

/merge

@ti-chi-bot
Copy link
Member Author

ti-chi-bot commented Apr 14, 2022

@fzhedu: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@fzhedu
Copy link
Contributor

fzhedu commented Apr 14, 2022

/merge

@ti-chi-bot
Copy link
Member Author

ti-chi-bot commented Apr 14, 2022

@fzhedu: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@fzhedu
Copy link
Contributor

fzhedu commented Apr 14, 2022

/merge
/merge

@ti-chi-bot
Copy link
Member Author

ti-chi-bot commented Apr 14, 2022

@fzhedu: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@fzhedu
Copy link
Contributor

fzhedu commented Apr 14, 2022

/merge

@ti-chi-bot
Copy link
Member Author

ti-chi-bot commented Apr 14, 2022

@fzhedu: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@JaySon-Huang JaySon-Huang added this to the v5.2.4 milestone Apr 14, 2022
@ti-chi-bot ti-chi-bot merged commit 0b823b4 into pingcap:release-5.2 Apr 14, 2022
@ti-chi-bot ti-chi-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Apr 22, 2022
@fzhedu fzhedu added the needs-cherry-pick-release-5.3 Type: Need cherry pick to release-5.3 label Jun 16, 2022
@fzhedu
Copy link
Contributor

fzhedu commented Jun 16, 2022

/run-cherry-picker

ti-chi-bot added a commit to ti-chi-bot/tiflash that referenced this pull request Jun 16, 2022
@ti-chi-bot
This is an automated cherry-pick of pingcap#4268
82d636b 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot mentioned this pull request Jun 16, 2022
Closed
12 tasks
@ti-chi-bot
Copy link
Member Author

ti-chi-bot commented Jun 16, 2022

In response to a cherrypick label: new pull request created: #5159.

fzhedu pushed a commit to ti-chi-bot/tiflash that referenced this pull request Jun 16, 2022
@ti-chi-bot @fzhedu
MPP: update the state of building a hash table when createOnce throw …
c1f6ab0 
…exceptions (pingcap#4202) (pingcap#4268)

close pingcap#4195
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@windtalker windtalker windtalker approved these changes

+1 more reviewer

@fzhedu fzhedu fzhedu approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@fzhedu fzhedu

Labels

cherry-pick-approved Cherry pick PR approved by release team. needs-cherry-pick-release-5.3 Type: Need cherry pick to release-5.3 release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug. type/cherry-pick-for-release-5.2

Projects

None yet

Milestone

v5.2.4

Development

Successfully merging this pull request may close these issues.

7 participants

@ti-chi-bot @CLAassistant @zanmato1984 @fzhedu @windtalker @JaySon-Huang @VelocityLight