support PartitionTableScan in TiFlash#3876
Merged
ti-chi-bot merged 9 commits intopingcap:masterfrom Mar 14, 2022
Merged
Conversation
Member
|
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. DetailsReviewer can indicate their review by submitting an approval review. |
f8e52b6 to
568b6a0
Compare
ab82cce to
d621cd6
Compare
d621cd6 to
195894e
Compare
Contributor
Author
|
/run-all-tests |
Collaborator
Coverage for changed filesCoverage summaryfull coverage report (for internal network access only) |
af699d5 to
0c80e6b
Compare
0c80e6b to
dd49eac
Compare
SeaRise
reviewed
Feb 28, 2022
dd49eac to
a53ec53
Compare
SeaRise
reviewed
Mar 1, 2022
6d87e1d to
b78aff1
Compare
fuzhe1989
approved these changes
Mar 14, 2022
Contributor
There was a problem hiding this comment.
Suggested change
| TablesRegionsInfo tables_regions_info = TablesRegionsInfo::create(cop_request->regions(), cop_request->table_regions(), cop_context.db_context.getTMTContext()); | |
| auto tables_regions_info = TablesRegionsInfo::create(cop_request->regions(), cop_request->table_regions(), cop_context.db_context.getTMTContext()); |
Contributor
There was a problem hiding this comment.
how about check all schemas the same under debug mode?
Contributor
There was a problem hiding this comment.
got it. btw I found tidb_table_ids and tiflash_table_ids are more readable to me.
Contributor
There was a problem hiding this comment.
what will happen if tidb mistakenly sent duplicated ids to tiflash? use set and check it?
Signed-off-by: xufei <xufeixw@mail.ustc.edu.cn>
Signed-off-by: xufei <xufeixw@mail.ustc.edu.cn>
Signed-off-by: xufei <xufeixw@mail.ustc.edu.cn>
Signed-off-by: xufei <xufeixw@mail.ustc.edu.cn>
Signed-off-by: xufei <xufeixw@mail.ustc.edu.cn>
Signed-off-by: xufei <xufeixw@mail.ustc.edu.cn>
01cce83 to
f7065bf
Compare
Contributor
Author
|
/cancel hold |
Contributor
Author
|
/merge |
Member
|
@windtalker: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests You only need to trigger If you have any questions about the PR merge process, please refer to pr process. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
Member
|
This pull request has been accepted and is ready to merge. DetailsCommit hash: f7065bf |
Contributor
|
/run-all-tests |
Contributor
|
/rebuild |
1 similar comment
Contributor
Author
|
/rebuild |
Contributor
|
/run-integration-tests |
Collaborator
Coverage for changed filesCoverage summaryfull coverage report (for internal network access only) |
ywqzzy
pushed a commit
to ywqzzy/tiflash_1
that referenced
this pull request
Mar 14, 2022
close pingcap#3873 Signed-off-by: ywqzzy <592838129@qq.com>
ywqzzy
added a commit
to ywqzzy/tiflash_1
that referenced
this pull request
Mar 14, 2022
Signed-off-by: ywqzzy <592838129@qq.com> update. Signed-off-by: ywqzzy <592838129@qq.com> update. Signed-off-by: ywqzzy <592838129@qq.com> Split write and ingest throughput (pingcap#4245) close pingcap#4243 Signed-off-by: ywqzzy <592838129@qq.com> fix the problem that expired data was not recycled timely due to slow gc speed (pingcap#4224) close pingcap#4146 Signed-off-by: ywqzzy <592838129@qq.com> PageStorage: Fix some bugs (pingcap#4212) ref pingcap#3594 Signed-off-by: ywqzzy <592838129@qq.com> Make test of CreateTables using affected opts (pingcap#4239) close pingcap#4235 Signed-off-by: ywqzzy <592838129@qq.com> BlobStore: remove the old_ids, not need recycle the blob id. (pingcap#4247) ref pingcap#3594 Signed-off-by: ywqzzy <592838129@qq.com> support `PartitionTableScan` in TiFlash (pingcap#3876) close pingcap#3873 Signed-off-by: ywqzzy <592838129@qq.com> update. Signed-off-by: ywqzzy <592838129@qq.com> update. Signed-off-by: ywqzzy <592838129@qq.com> support last_day and dayofmonth pushdown to tiflash (pingcap#4183) close pingcap#4149 Signed-off-by: ywqzzy <592838129@qq.com>
JaySon-Huang
pushed a commit
to JaySon-Huang/tiflash
that referenced
this pull request
Mar 17, 2022
12 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #3873
Problem Summary:
As the issue described.
What is changed and how it works?
This is the TiFlash part of #3873, the main changes include
TiDBTableScanto hide the different ofTableScanandPartitionTableScanPartitionTableScaninDAGStorageInterpreterPartitionTableScanindbgFunctionCoprocessorCheck List
Tests
Side effects
Documentation
Release note