Skip to content

FLASH-674: check region version in executeTS#322

Merged
windtalker merged 13 commits intopingcap:masterfrom
windtalker:master
Nov 18, 2019
Merged

FLASH-674: check region version in executeTS#322
windtalker merged 13 commits intopingcap:masterfrom
windtalker:master

Conversation

@windtalker
Copy link
Contributor

No description provided.

Copy link
Contributor

@zanmato1984 zanmato1984 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zanmato1984 zanmato1984 changed the title check region version in executeTS FLASH-674: check region version in executeTS Nov 14, 2019
@windtalker
Copy link
Contributor Author

/run-integration-tests

@windtalker windtalker merged commit 0acced4 into pingcap:master Nov 18, 2019
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should add one more check:

if (current_region->isPendingRemove())
     // throw RegionException(..., RegionException::RegionReadStatus::PENDING_REMOVE);

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, region status should also be checked here

JaySon-Huang pushed a commit to JaySon-Huang/tiflash that referenced this pull request Dec 3, 2024
Signed-off-by: Calvin Neo <calvinneo1995@gmail.com>
CalvinNeo added a commit to CalvinNeo/tiflash that referenced this pull request Dec 30, 2024
Signed-off-by: Calvin Neo <calvinneo1995@gmail.com>
ti-chi-bot pushed a commit to ti-chi-bot/tiflash that referenced this pull request Jan 7, 2025
Signed-off-by: Calvin Neo <calvinneo1995@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants