[FLASH-549/550/626] Remove obsoleted data in Engine DeltaMerge#292
Merged
JaySon-Huang merged 9 commits intopingcap:DeltaMergeEnginefrom Nov 12, 2019
Merged
Conversation
flowbehappy
reviewed
Oct 28, 2019
flowbehappy
reviewed
Oct 28, 2019
Contributor
There was a problem hiding this comment.
We should keep this value here, and use a min_version_last_upate_time to prevent frequently update this value.
Contributor
Author
There was a problem hiding this comment.
Ok.
And I add dm_safe_point_update_interval_seconds in Settings with default 60 seconds (which is the same interval of TiKV)
JaySon-Huang
commented
Oct 29, 2019
5d16c9a to
72155c7
Compare
Contributor
Author
|
/run-integration-tests |
2 similar comments
Contributor
Author
|
/run-integration-tests |
Contributor
Author
|
/run-integration-tests |
8cd9c93 to
4e99b57
Compare
Contributor
Author
|
/rebuild |
1 similar comment
Contributor
Author
|
/rebuild |
4e99b57 to
766a9f9
Compare
JaySon-Huang
commented
Oct 31, 2019
766a9f9 to
a8bdbd7
Compare
a8bdbd7 to
54c51ec
Compare
7257e74 to
d6e8b20
Compare
54c51ec to
5e9b62f
Compare
Contributor
|
LGTM |
12 tasks
CalvinNeo
pushed a commit
to CalvinNeo/tiflash
that referenced
this pull request
Sep 23, 2024
Signed-off-by: Wish <breezewish@outlook.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.