[FLASH-469/452/462] DM: Rename column, read with specify tso, schema-version#234
Merged
JaySon-Huang merged 9 commits intopingcap:DeltaMergeEnginefrom Sep 18, 2019
Merged
Conversation
75eac24 to
522e7a3
Compare
Contributor
Author
|
/run-integration-tests |
522e7a3 to
a90b972
Compare
Contributor
Author
|
/run-integration-tests |
Contributor
Author
|
/run-integration-tests |
Contributor
Author
We need to rebase branch DeltaMergeEngine to master.. |
a1adbe5 to
2633845
Compare
2. Support rename column && identify column by id in DeltaMerge DDL
…ent version is old) Note that we still not support time travel read now 2. Support read with specify tso 3. Add test cases for read with specify tso through raft
d55f26a to
95fe78e
Compare
Contributor
Author
|
/run-integration-tests |
Contributor
Author
|
Exception thrown when running DataTypeDate(DataTypeUInt16 in actual), DataTypeDateTime(DataTypeUInt32 in actual), but we generate wrong type of MinMaxIndex in these lines. Fixed those lines to use |
Contributor
Author
|
/build |
Contributor
Author
|
/run-integration-tests |
flowbehappy
reviewed
Sep 18, 2019
| } | ||
| else if (command.type == AlterCommand::RENAME_COLUMN) | ||
| { | ||
| for (auto && c : table_columns) |
Contributor
There was a problem hiding this comment.
for ()
{
multiple lines
}
Contributor
|
LGTM |
flowbehappy
approved these changes
Sep 18, 2019
JaySon-Huang
added a commit
to JaySon-Huang/tiflash
that referenced
this pull request
Sep 23, 2019
…version (pingcap#234) * Support rename column in DeltaMerge tables * Read with specify tso / schema version by override client settings * Add some tests for MVCC filter * `IManageableStorage::check` to `IManageableStorage::checkStatus`, because it hide the function of `ITableDeclaration::check` * Fix bug in MinMaxIndex of DataTypeDate and DataTypeDateTime
JaySon-Huang
added a commit
to JaySon-Huang/tiflash
that referenced
this pull request
Sep 23, 2019
…version (pingcap#234) * Support rename column in DeltaMerge tables * Read with specify tso / schema version by override client settings * Add some tests for MVCC filter * `IManageableStorage::check` to `IManageableStorage::checkStatus`, because it hide the function of `ITableDeclaration::check` * Fix bug in MinMaxIndex of DataTypeDate and DataTypeDateTime
JaySon-Huang
added a commit
that referenced
this pull request
Sep 26, 2019
…version (#234) * Support rename column in DeltaMerge tables * Read with specify tso / schema version by override client settings * Add some tests for MVCC filter * `IManageableStorage::check` to `IManageableStorage::checkStatus`, because it hide the function of `ITableDeclaration::check` * Fix bug in MinMaxIndex of DataTypeDate and DataTypeDateTime
JaySon-Huang
added a commit
to JaySon-Huang/tiflash
that referenced
this pull request
Oct 17, 2019
…version (pingcap#234) * Support rename column in DeltaMerge tables * Read with specify tso / schema version by override client settings * Add some tests for MVCC filter * `IManageableStorage::check` to `IManageableStorage::checkStatus`, because it hide the function of `ITableDeclaration::check` * Fix bug in MinMaxIndex of DataTypeDate and DataTypeDateTime
JaySon-Huang
added a commit
to JaySon-Huang/tiflash
that referenced
this pull request
Oct 18, 2019
…version (pingcap#234) * Support rename column in DeltaMerge tables * Read with specify tso / schema version by override client settings * Add some tests for MVCC filter * `IManageableStorage::check` to `IManageableStorage::checkStatus`, because it hide the function of `ITableDeclaration::check` * Fix bug in MinMaxIndex of DataTypeDate and DataTypeDateTime
JaySon-Huang
added a commit
that referenced
this pull request
Oct 22, 2019
…version (#234) * Support rename column in DeltaMerge tables * Read with specify tso / schema version by override client settings * Add some tests for MVCC filter * `IManageableStorage::check` to `IManageableStorage::checkStatus`, because it hide the function of `ITableDeclaration::check` * Fix bug in MinMaxIndex of DataTypeDate and DataTypeDateTime
JaySon-Huang
added a commit
to JaySon-Huang/tiflash
that referenced
this pull request
Oct 23, 2019
…version (pingcap#234) * Support rename column in DeltaMerge tables * Read with specify tso / schema version by override client settings * Add some tests for MVCC filter * `IManageableStorage::check` to `IManageableStorage::checkStatus`, because it hide the function of `ITableDeclaration::check` * Fix bug in MinMaxIndex of DataTypeDate and DataTypeDateTime
JaySon-Huang
added a commit
to JaySon-Huang/tiflash
that referenced
this pull request
Oct 30, 2019
…version (pingcap#234) * Support rename column in DeltaMerge tables * Read with specify tso / schema version by override client settings * Add some tests for MVCC filter * `IManageableStorage::check` to `IManageableStorage::checkStatus`, because it hide the function of `ITableDeclaration::check` * Fix bug in MinMaxIndex of DataTypeDate and DataTypeDateTime
JaySon-Huang
added a commit
to JaySon-Huang/tiflash
that referenced
this pull request
Nov 1, 2019
…version (pingcap#234) * Support rename column in DeltaMerge tables * Read with specify tso / schema version by override client settings * Add some tests for MVCC filter * `IManageableStorage::check` to `IManageableStorage::checkStatus`, because it hide the function of `ITableDeclaration::check` * Fix bug in MinMaxIndex of DataTypeDate and DataTypeDateTime
JaySon-Huang
added a commit
to JaySon-Huang/tiflash
that referenced
this pull request
Nov 1, 2019
…version (pingcap#234) * Support rename column in DeltaMerge tables * Read with specify tso / schema version by override client settings * Add some tests for MVCC filter * `IManageableStorage::check` to `IManageableStorage::checkStatus`, because it hide the function of `ITableDeclaration::check` * Fix bug in MinMaxIndex of DataTypeDate and DataTypeDateTime
JaySon-Huang
added a commit
to JaySon-Huang/tiflash
that referenced
this pull request
Nov 5, 2019
…version (pingcap#234) * Support rename column in DeltaMerge tables * Read with specify tso / schema version by override client settings * Add some tests for MVCC filter * `IManageableStorage::check` to `IManageableStorage::checkStatus`, because it hide the function of `ITableDeclaration::check` * Fix bug in MinMaxIndex of DataTypeDate and DataTypeDateTime
JaySon-Huang
pushed a commit
to JaySon-Huang/tiflash
that referenced
this pull request
Aug 2, 2024
Signed-off-by: Wish <breezewish@outlook.com>
JaySon-Huang
pushed a commit
that referenced
this pull request
Aug 6, 2024
Signed-off-by: Wish <breezewish@outlook.com>
Lloyd-Pottiger
pushed a commit
to Lloyd-Pottiger/tiflash
that referenced
this pull request
Sep 20, 2024
Signed-off-by: Wish <breezewish@outlook.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
IManageableStorage::checktoIManageableStorage::checkStatus, because it hide the function ofITableDeclaration::check