Skip to content

fix potential mpp task leak#2338

Merged
windtalker merged 3 commits intopingcap:masterfrom
windtalker:mpp_task_leak
Jul 7, 2021
Merged

fix potential mpp task leak#2338
windtalker merged 3 commits intopingcap:masterfrom
windtalker:mpp_task_leak

Conversation

@windtalker
Copy link
Contributor

@windtalker windtalker commented Jul 6, 2021

What problem does this PR solve?

Issue Number: close #2322

Problem Summary:
As the issue decribed.

What is changed and how it works?

Proposal: xxx

What's Changed:

  1. catch exception for each tunnel during MPPTask::writeErrToAllTunnel
  2. make sure finished flag is set in MPPTunnel::close()
  3. Do not hold sender task in EstablishMPPConnection

Related changes

  • PR to update pingcap/docs/pingcap/docs-cn:
  • Need to cherry-pick to the release branch:

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

Release note

  • fix potential mpp task leak

@windtalker windtalker requested a review from hanfei1991 July 6, 2021 09:42
JaySon-Huang
JaySon-Huang reviewed Jul 6, 2021
View reviewed changes
@windtalker windtalker added needs-cherry-pick-release-5.0 PR which needs to be cherry-picked to release-5.0 needs-cherry-pick-release-5.1 PR which needs to be cherry-picked to release-5.1 type/bugfix This PR fixes a bug. labels Jul 6, 2021
@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 6, 2021
@windtalker
Copy link
Contributor Author

windtalker commented Jul 7, 2021

/run-all-tests

@windtalker windtalker merged commit f0733d9 into pingcap:master Jul 7, 2021
@windtalker windtalker deleted the mpp_task_leak branch July 7, 2021 03:34
@ti-srebot ti-srebot mentioned this pull request Jul 7, 2021
Merged
@ti-srebot
Copy link
Collaborator

ti-srebot commented Jul 7, 2021

cherry pick to release-5.0 in PR #2340

@ti-srebot ti-srebot mentioned this pull request Jul 7, 2021
Merged
@ti-srebot
Copy link
Collaborator

ti-srebot commented Jul 7, 2021

cherry pick to release-5.1 in PR #2341

flowbehappy pushed a commit that referenced this pull request Jul 9, 2021
@windtalker
fix potential mpp task leak (#2338) (#2358)
fbb0715 
* save work

* add tests

* add more tests
ti-srebot added a commit that referenced this pull request Jul 15, 2021
@ti-srebot
fix potential mpp task leak (#2338) (#2341)
4eda3a5
ti-srebot added a commit that referenced this pull request Jul 19, 2021
@ti-srebot
fix potential mpp task leak (#2338) (#2340)
2743b08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JaySon-Huang JaySon-Huang JaySon-Huang left review comments

+1 more reviewer

@hanfei1991 hanfei1991 hanfei1991 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

needs-cherry-pick-release-5.0 PR which needs to be cherry-picked to release-5.0 needs-cherry-pick-release-5.1 PR which needs to be cherry-picked to release-5.1 status/LGT1 Indicates that a PR has LGTM 1. type/bugfix This PR fixes a bug.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

MPPTask::runImpl is not exception safe

4 participants

@windtalker @ti-srebot @JaySon-Huang @hanfei1991