Make the max expected number of legacy files and max valid rate configurable (#2187)#2205
Merged
JaySon-Huang merged 2 commits intopingcap:release-5.1from Jun 28, 2021
Merged
Conversation
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
Contributor
|
/merge |
Contributor
|
/run-all-tests |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cherry-pick #2187 to release-5.1
You can switch your code base to this Pull Request by using git-extras:
# In tics repo: git pr https://github.com/pingcap/tics/pull/2205After apply modifications, you can push your change to this PR via:
Signed-off-by: JaySon-Huang jayson.hjs@gmail.com
What problem does this PR solve?
Issue Number: related to #2169 , #1552
Problem Summary:
In #1552, we introduce an adaptive aggressive GC strategy for PageStorage. If there are more than 100 legacy files, we will set the
gc_max_valid_rateto 1.0 try to compact all PageFiles even if there are no invalid pages inside one PageFile.It brings some trouble in extreme cases like #2169 more worst and generates more write flow.
What is changed and how it works?
dt_page_num_max_expect_legacy_filesanddt_page_num_max_gc_valid_rateto make then configurable.gc_max_valid_rate_boundfrom 1.00 to 0.95RegionPersisterRelated changes
pingcap/docs/pingcap/docs-cn:Check List
Tests
Side effects
Release note