Fix bug for ingesting data to a "pk is handle" table#2125
Merged
JaySon-Huang merged 3 commits intopingcap:masterfrom Jun 10, 2021
Merged
Fix bug for ingesting data to a "pk is handle" table#2125JaySon-Huang merged 3 commits intopingcap:masterfrom
JaySon-Huang merged 3 commits intopingcap:masterfrom
Conversation
Signed-off-by: JaySon-Huang <jayson.hjs@gmail.com>
Signed-off-by: JaySon-Huang <jayson.hjs@gmail.com>
Contributor
Author
|
/run-all-tests |
Contributor
Author
|
/run-all-tests |
Collaborator
|
cherry pick to release-4.0 in PR #2127 |
Collaborator
|
cherry pick to release-5.0 in PR #2128 |
Collaborator
|
cherry pick to release-5.1 in PR #2129 |
JaySon-Huang
added a commit
that referenced
this pull request
Jun 11, 2021
Signed-off-by: ti-srebot <ti-srebot@pingcap.com> Co-authored-by: JaySon <tshent@qq.com>
JaySon-Huang
added a commit
that referenced
this pull request
Jun 16, 2021
JaySon-Huang
added a commit
that referenced
this pull request
Jun 17, 2021
Co-authored-by: JaySon <tshent@qq.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #2118
Problem Summary:
DeltaTree add a "_tidb_rowid" column to the table even if "pk is handle" is true. We use the
FunctionToInt64to copy data from the primary key column to the handle column under this situation.https://github.com/pingcap/tics/blob/1078d0b8199a1cfe54d73623ea8da636505f419b/dbms/src/Storages/DeltaMerge/DeltaMergeStore.cpp#L403-L410
However, if the types are identical,
FunctionToInt64only does a shallow copy and makes the primary key column and_tidb_rowidshare the same column ptr when "pk is handle".https://github.com/pingcap/tics/blob/1078d0b8199a1cfe54d73623ea8da636505f419b/dbms/src/Functions/FunctionsConversion.h#L832-L841
After that, we need to reorganize the boundary of blocks, this makes us append some rows into the pk column and handle column. Unfortunately, they share the same column pointer, which makes the columns inside one block don't align and make trouble for later processing.
https://github.com/pingcap/tics/blob/1078d0b8199a1cfe54d73623ea8da636505f419b/dbms/src/Storages/DeltaMerge/PKSquashingBlockInputStream.h#L75-L99
What is changed and how it works?
Use deep copy instead of shallow copy when the types are identical in
DeltaMergeStore::addExtraColumnIfNeed.Related changes
pingcap/docs/pingcap/docs-cn:Check List
Tests
Side effects
Release note