*: fix redefinition of 128-bits numeric_limit#2102
Closed
SchrodingerZhu wants to merge 1 commit intopingcap:masterfrom
Closed
*: fix redefinition of 128-bits numeric_limit#2102SchrodingerZhu wants to merge 1 commit intopingcap:masterfrom
SchrodingerZhu wants to merge 1 commit intopingcap:masterfrom
Conversation
f779898 to
35deb4b
Compare
409d825 to
bb1842f
Compare
Signed-off-by: SchrodingerZhu <i@zhuyi.fan>
Contributor
Author
|
/run-all-tests |
fuzhe1989
reviewed
Jun 10, 2021
| else () | ||
| set (CMAKE_CXX_STANDARD 17) | ||
| set (CMAKE_CXX_EXTENSIONS 0) # https://cmake.org/cmake/help/latest/prop_tgt/CXX_EXTENSIONS.html#prop_tgt:CXX_EXTENSIONS | ||
| if (CMAKE_COMPILER_IS_GNUCC AND CMAKE_CXX_COMPILER_VERSION VERSION_GREATER 8.0) |
Contributor
There was a problem hiding this comment.
seems gcc-7 already has __int128 support.
If we can assume the compiler won't older than gcc-7 then we can always enable this extension.
Contributor
Author
|
closed in favor of #2139 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: SchrodingerZhu i@zhuyi.fan
What problem does this PR solve?
Issue Number: #2064
Problem Summary:
Related macros is defined only with
gnu c++ extensionnow.What is changed and how it works?
Proposal: xxx
What's Changed:
enable gnu extension for modern compilers.
Check List
Tests
Release note
No release note