Skip to content

cmake: Remove useless CMAKE_CXX_FLAGS and enable CMAKE_CXX_EXTENSIONS#2139

Merged
ti-srebot merged 5 commits intopingcap:masterfrom
fuzhe1989:fuzhe/port_ch/cmake
Jun 11, 2021
Merged

cmake: Remove useless CMAKE_CXX_FLAGS and enable CMAKE_CXX_EXTENSIONS#2139
ti-srebot merged 5 commits intopingcap:masterfrom
fuzhe1989:fuzhe/port_ch/cmake

Conversation

@fuzhe1989
Copy link
Contributor

Extra changes:

  1. Ignore warnings of type unused-function and unused-variable.

@fuzhe1989 fuzhe1989 requested a review from leiysky June 11, 2021 07:18
@fuzhe1989
Copy link
Contributor Author

/run-all-tests

1 similar comment
@fuzhe1989
Copy link
Contributor Author

/run-all-tests

@fuzhe1989
Copy link
Contributor Author

/run-all-tests

Copy link
Contributor

@leiysky leiysky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Jun 11, 2021
@leiysky
Copy link
Contributor

leiysky commented Jun 11, 2021

/merge

@ti-srebot ti-srebot added the status/can-merge Indicates a PR has been approved by a committer. label Jun 11, 2021
@ti-srebot
Copy link
Collaborator

/run-all-tests

@ti-srebot ti-srebot merged commit ed728b7 into pingcap:master Jun 11, 2021
@fuzhe1989 fuzhe1989 deleted the fuzhe/port_ch/cmake branch June 11, 2021 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants