Skip to content

[flash-423] fix ch fail to start when tidb cluster is not ready.#203

Merged
hanfei1991 merged 4 commits intomasterfrom
hanfei-ddl/boostrap
Aug 27, 2019
Merged

[flash-423] fix ch fail to start when tidb cluster is not ready.#203
hanfei1991 merged 4 commits intomasterfrom
hanfei-ddl/boostrap

Conversation

@hanfei1991
Copy link
Member

@hanfei1991 hanfei1991 commented Aug 26, 2019

retry in an endless loop. By the way, I have tested manually :D

@hanfei1991 hanfei1991 requested a review from zanmato1984 August 26, 2019 12:59
@hanfei1991
Copy link
Member Author

/run-integration-tests

2 similar comments
@hanfei1991
Copy link
Member Author

/run-integration-tests

@hanfei1991
Copy link
Member Author

/run-integration-tests

@hanfei1991
Copy link
Member Author

/run-integration-tests

1 similar comment
@hanfei1991
Copy link
Member Author

/run-integration-tests


/// Then, sync schemas with TiDB, and initialize schema sync service.
global_context->getTMTContext().getSchemaSyncer()->syncSchemas(*global_context);
for (;;)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a retry times?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

catch (Poco::Exception & e)
{
LOG_ERROR(log, "Bootstrap failed because sync schema error: " << e.displayText() << "\n We will sleep 3 seconds and try again.");
::sleep(3);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sleep(1) is good, will not occupy much CPU

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@hanfei1991
Copy link
Member Author

/run-integration-tests

@hanfei1991
Copy link
Member Author

@innerr PTAL again

Copy link
Contributor

@innerr innerr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hanfei1991 hanfei1991 merged commit 1a9376b into master Aug 27, 2019
@hanfei1991 hanfei1991 deleted the hanfei-ddl/boostrap branch August 27, 2019 16:18
JaySon-Huang added a commit to JaySon-Huang/tiflash that referenced this pull request Aug 2, 2024
Signed-off-by: Wish <breezewish@outlook.com>
Signed-off-by: Lloyd-Pottiger <yan1579196623@gmail.com>
Co-authored-by: Wish <breezewish@outlook.com>
Co-authored-by: JaySon-Huang <tshent@qq.com>
JaySon-Huang added a commit that referenced this pull request Aug 6, 2024
Signed-off-by: Wish <breezewish@outlook.com>
Signed-off-by: Lloyd-Pottiger <yan1579196623@gmail.com>
Co-authored-by: Wish <breezewish@outlook.com>
Co-authored-by: JaySon-Huang <tshent@qq.com>
Lloyd-Pottiger added a commit to Lloyd-Pottiger/tiflash that referenced this pull request Aug 28, 2024
Signed-off-by: Wish <breezewish@outlook.com>
Signed-off-by: Lloyd-Pottiger <yan1579196623@gmail.com>
Co-authored-by: Wish <breezewish@outlook.com>
Co-authored-by: JaySon-Huang <tshent@qq.com>
Lloyd-Pottiger added a commit to Lloyd-Pottiger/tiflash that referenced this pull request Aug 30, 2024
Signed-off-by: Wish <breezewish@outlook.com>
Signed-off-by: Lloyd-Pottiger <yan1579196623@gmail.com>
Co-authored-by: Wish <breezewish@outlook.com>
Co-authored-by: JaySon-Huang <tshent@qq.com>
Lloyd-Pottiger added a commit to Lloyd-Pottiger/tiflash that referenced this pull request Sep 5, 2024
Signed-off-by: Wish <breezewish@outlook.com>
Signed-off-by: Lloyd-Pottiger <yan1579196623@gmail.com>
Co-authored-by: Wish <breezewish@outlook.com>
Co-authored-by: JaySon-Huang <tshent@qq.com>
Lloyd-Pottiger added a commit to Lloyd-Pottiger/tiflash that referenced this pull request Sep 6, 2024
Signed-off-by: Wish <breezewish@outlook.com>
Signed-off-by: Lloyd-Pottiger <yan1579196623@gmail.com>
Co-authored-by: Wish <breezewish@outlook.com>
Co-authored-by: JaySon-Huang <tshent@qq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants