Skip to content

Fix the bug that some decoding is not protected by alter_lock#1945

Merged
JaySon-Huang merged 1 commit intopingcap:masterfrom
JaySon-Huang:fix_alter_lock
May 26, 2021
Merged

Fix the bug that some decoding is not protected by alter_lock#1945
JaySon-Huang merged 1 commit intopingcap:masterfrom
JaySon-Huang:fix_alter_lock

Conversation

@JaySon-Huang
Copy link
Contributor

Signed-off-by: JaySon-Huang jayson.hjs@gmail.com

What problem does this PR solve?

Issue Number: close #1944

We should use lockStructureForShare instead of lockForShare in GenRegionBlockDatawithSchema and AtomicGetStorageSchema.

What is changed and how it works?

Review lockForShare and lockStructureForShare in decoding block phase, fix bugs and comments.

Related changes

  • Need to cherry-pick to the release branch: 5.0

Check List

Tests

  • Manual test (add detailed scripts or steps below)

Side effects

Release note

  • No release note

Signed-off-by: JaySon-Huang <jayson.hjs@gmail.com>
@JaySon-Huang JaySon-Huang added the type/bugfix This PR fixes a bug. label May 20, 2021
@JaySon-Huang JaySon-Huang requested a review from zanmato1984 May 20, 2021 15:36
@JaySon-Huang JaySon-Huang self-assigned this May 20, 2021
@JaySon-Huang
Copy link
Contributor Author

/run-all-tests

Copy link
Contributor

@zanmato1984 zanmato1984 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label May 26, 2021
@JaySon-Huang JaySon-Huang merged commit ea6446a into pingcap:master May 26, 2021
@JaySon-Huang JaySon-Huang deleted the fix_alter_lock branch May 26, 2021 07:11
jiangyuzhao pushed a commit to JaySon-Huang/tiflash that referenced this pull request Jun 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status/LGT1 Indicates that a PR has LGTM 1. type/bugfix This PR fixes a bug.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Segmentation fault when PreHandleSnapshot

3 participants