Fix bug for remote reading using "double lock" strategy#1926
Merged
ti-srebot merged 8 commits intopingcap:masterfrom May 19, 2021
Merged
Fix bug for remote reading using "double lock" strategy#1926ti-srebot merged 8 commits intopingcap:masterfrom
ti-srebot merged 8 commits intopingcap:masterfrom
Conversation
…ame safe point when there is any error Signed-off-by: JaySon-Huang <jayson.hjs@gmail.com>
zanmato1984
reviewed
May 18, 2021
Signed-off-by: JaySon-Huang <jayson.hjs@gmail.com>
Contributor
Author
|
/run-all-tests |
zanmato1984
reviewed
May 19, 2021
zanmato1984
reviewed
May 19, 2021
Signed-off-by: JaySon-Huang <jayson.hjs@gmail.com>
zanmato1984
reviewed
May 19, 2021
zanmato1984
reviewed
May 19, 2021
zanmato1984
reviewed
May 19, 2021
zanmato1984
reviewed
May 19, 2021
| } | ||
| else | ||
| { | ||
| // Don't update last_gc_safe_point and retry later |
Contributor
There was a problem hiding this comment.
So that the next round GC will be more aggressive? Because the "current" timestamp is even further from the "last GC safe point"?
Contributor
Author
There was a problem hiding this comment.
Yes, it will be more aggressive if the gc_safe_point succeeds.
In my simple manual test, the gc_safe_point in PD didn't get update unless I insert lots of rows. So I think we should allow running GC with the same gc_safe_point to reclaim disk space if it does not succeed.
Signed-off-by: JaySon-Huang <jayson.hjs@gmail.com>
Contributor
Author
|
/merge |
Collaborator
|
/run-all-tests |
Collaborator
|
@JaySon-Huang merge failed. |
Contributor
Author
|
/merge |
Collaborator
|
/run-all-tests |
JaySon-Huang
added a commit
to JaySon-Huang/tiflash
that referenced
this pull request
May 23, 2021
Conflicts: dbms/src/Storages/DeltaMerge/DeltaMergeStore.cpp
zanmato1984
pushed a commit
that referenced
this pull request
May 23, 2021
…r TiFlash (for POC) (#1973) * Remove ReplicatedMergeTree family (#1805) * Eliminate the table lock between reading,writing and DDL operators for TiFlash (#1736) 1. Port the latest `RWLock` for `IStorage` from Clickhouse. "phase-fair rwlocks have been shown to provide more predictable timings compared to task-fair rwlocks for certain workloads (for relatively low share of writes, <25%). Brandenburg B, Anderson J, (2010)" 2. Refactor the lock model for `IStorage` to eliminate the lock between reading, writing, and DDL operations. 3. Acquire table lock by QueryID/threadName instead of function name 3. Tombstone the database after receiving a "drop" DDL from TiDB. Physically drop the databases / tables after gc safe point. 3. Remove some outdated tests under `tests/mutable-test/txn_schema` (all those tests are ported into `tests/delta-merge-test/raft/schema`) Signed-off-by: JaySon-Huang <jayson.hjs@gmail.com> Conflicts: dbms/src/Databases/test/gtest_database.cpp dbms/src/Storages/GCManager.cpp dbms/src/Storages/Transaction/ApplySnapshot.cpp dbms/src/Storages/Transaction/PartitionStreams.cpp * Fix bug for remote reading using "double lock" strategy (#1926) Conflicts: dbms/src/Storages/DeltaMerge/DeltaMergeStore.cpp * Fix the bug that some decoding is not protected by alter_lock Signed-off-by: JaySon-Huang <jayson.hjs@gmail.com> Conflicts: dbms/src/Storages/Transaction/ApplySnapshot.cpp dbms/src/Storages/Transaction/PartitionStreams.cpp
jiangyuzhao
pushed a commit
to JaySon-Huang/tiflash
that referenced
this pull request
Jun 21, 2021
Conflicts: dbms/src/Storages/DeltaMerge/DeltaMergeStore.cpp
Contributor
Author
|
Have been merged into #1858 to release-5.0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: JaySon-Huang jayson.hjs@gmail.com
What problem does this PR solve?
Fix some bugs brought by #1736 :
What is changed and how it works?
null_stream_if_emptybytable_structure_lockSchemaSyncService::last_gc_safe_pointif there is any error while doing GC so that we can try with the same gc_safe_point later.DBGInvoke gc_schemas([gc_safe_point])for debugging schema gcRelated changes
Check List
Tests
https://docs.google.com/document/d/1ibpObKdnCOlWLke3eXFBc8904N7I4MdQTNSqtGWB4Xo/edit#heading=h.ncbbmspb17uv
Side effects
Release note