Skip to content

[flash-365] support db filters#164

Merged
zanmato1984 merged 7 commits intomasterfrom
hanfei-ddl/db_filter
Aug 8, 2019
Merged

[flash-365] support db filters#164
zanmato1984 merged 7 commits intomasterfrom
hanfei-ddl/db_filter

Conversation

@hanfei1991
Copy link
Member

No description provided.

@hanfei1991 hanfei1991 requested a review from zanmato1984 August 7, 2019 06:12
@zanmato1984
Copy link
Contributor


Int64 getVersion() { return version; }

std::vector<String> getTableNames(const String & db_name);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use void traverseTables(std::function<void(TablePtr)> f) instead of making new function.

@hanfei1991
Copy link
Member Author

./run-integration-tests

Copy link
Contributor

@zanmato1984 zanmato1984 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zanmato1984 zanmato1984 merged commit 8997bd3 into master Aug 8, 2019
@zanmato1984 zanmato1984 deleted the hanfei-ddl/db_filter branch August 8, 2019 05:46
JaySon-Huang pushed a commit to JaySon-Huang/tiflash that referenced this pull request Aug 6, 2024
…d tables (pingcap#164)

Signed-off-by: Wish <breezewish@outlook.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants