Skip to content

Log redact for client-c#1306

Merged
JaySon-Huang merged 2 commits intopingcap:masterfrom
JaySon-Huang:redact_log_client_c
Dec 24, 2020
Merged

Log redact for client-c#1306
JaySon-Huang merged 2 commits intopingcap:masterfrom
JaySon-Huang:redact_log_client_c

Conversation

@JaySon-Huang
Copy link
Contributor

@JaySon-Huang JaySon-Huang commented Dec 24, 2020 •
edited
Loading

Signed-off-by: JaySon-Huang tshent@qq.com

What problem does this PR solve?

Issue Number: a part of #1277

Problem Summary: Avoid printing user data (client-c resolve lock error) to the logging file.

What is changed and how it works?

Update client-c and set redact flag for client-c

Related changes

  • Need to cherry-pick to the release branch 5.0-rc

Check List

Tests

  • Manual test (add detailed scripts or steps below)

Side effects

  • Performance regression
    • Consumes more CPU

Release note

  • No release note

@JaySon-Huang
Redact log for client-c
7a11f44 
Signed-off-by: JaySon-Huang <tshent@qq.com>
@JaySon-Huang JaySon-Huang added the needs-cherry-pick-release-5.0-rc PR which needs to be cherry-picked to release-5.0-rc label Dec 24, 2020
@JaySon-Huang JaySon-Huang self-assigned this Dec 24, 2020
@JaySon-Huang
Copy link
Contributor Author

JaySon-Huang commented Dec 24, 2020

/run-all-tests

hanfei1991
hanfei1991 approved these changes Dec 24, 2020
View reviewed changes
Copy link
Member

@hanfei1991 hanfei1991 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Dec 24, 2020
@JaySon-Huang
Copy link
Contributor Author

JaySon-Huang commented Dec 24, 2020

/run-all-tests

@JaySon-Huang JaySon-Huang merged commit 83bf325 into pingcap:master Dec 24, 2020
@ti-srebot ti-srebot mentioned this pull request Dec 24, 2020
Merged
@ti-srebot
Copy link
Collaborator

ti-srebot commented Dec 24, 2020

cherry pick to release-5.0-rc in PR #1309

zanmato1984 pushed a commit that referenced this pull request Dec 24, 2020
@ti-srebot @JaySon-Huang
Log redact for client-c (#1306) (#1309)
89f0ca0 
* Redact log for client-c

Signed-off-by: JaySon-Huang <tshent@qq.com>

* Fix build

Co-authored-by: JaySon-Huang <tshent@qq.com>
Co-authored-by: JaySon-Huang <jayson.hjs@gmail.com>
@JaySon-Huang JaySon-Huang deleted the redact_log_client_c branch December 25, 2020 04:26
@JaySon-Huang JaySon-Huang mentioned this pull request Dec 25, 2020
Closed
7 tasks
JaySon-Huang added a commit to JaySon-Huang/tiflash that referenced this pull request Dec 29, 2020
@JaySon-Huang
Log redact for client-c (pingcap#1306)
11fb025 
* Redact log for client-c

Signed-off-by: JaySon-Huang <tshent@qq.com>
@JaySon-Huang JaySon-Huang mentioned this pull request Dec 29, 2020
Merged
JaySon-Huang added a commit that referenced this pull request Dec 31, 2020
@JaySon-Huang
Redact log (release-4.0) (#1333)
d54685e 
* [Redact log] Redact key range and value in RSFilter from logging (#1282)
* Log redact for client-c (#1306)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@hanfei1991 hanfei1991 hanfei1991 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@JaySon-Huang JaySon-Huang

Labels

needs-cherry-pick-release-5.0-rc PR which needs to be cherry-picked to release-5.0-rc status/LGT1 Indicates that a PR has LGTM 1.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@JaySon-Huang @ti-srebot @hanfei1991