Raft: Revert the cpp logging changes from #10515#10541
Merged
ti-chi-bot[bot] merged 2 commits intopingcap:release-8.5from Nov 10, 2025
Merged
Raft: Revert the cpp logging changes from #10515#10541ti-chi-bot[bot] merged 2 commits intopingcap:release-8.5from
ti-chi-bot[bot] merged 2 commits intopingcap:release-8.5from
Conversation
… some related logs (pingcap#10515)" This reverts commit 5787a3a.
Signed-off-by: JaySon-Huang <tshent@qq.com>
Contributor
Author
|
/hold |
Contributor
Author
|
/unhold |
JinheLin
approved these changes
Nov 10, 2025
Lloyd-Pottiger
approved these changes
Nov 10, 2025
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JinheLin, Lloyd-Pottiger The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Contributor
[LGTM Timeline notifier]Timeline:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #10540
Problem Summary:
As the issue described, #10494 introduce consistency failure issue. And the changes was cherry-pick to release-8.5 branch by #10515
From the failure test logging #10510 (comment), we can see that all of those failure read request meet an
RegionException: ... message: Region error STALE_COMMAND(). #10494 adds new enum values includingSTALE_COMMANDinRegionException:: RegionReadStatus.What is changed and how it works?
Revert the CPP logging changes from #10515. Only keep the tiflash-proxy commit update.
Check List
Tests
Side effects
Documentation
Release note