Skip to content

Raft: add logging about read index failure#10494

Merged
ti-chi-bot[bot] merged 4 commits intopingcap:masterfrom
JaySon-Huang:refine_read_index_process
Oct 22, 2025
Merged

Raft: add logging about read index failure#10494
ti-chi-bot[bot] merged 4 commits intopingcap:masterfrom
JaySon-Huang:refine_read_index_process

Conversation

@JaySon-Huang
Copy link
Contributor

@JaySon-Huang JaySon-Huang commented Oct 22, 2025 •
edited
Loading

What problem does this PR solve?

Issue Number: close #10495

Problem Summary:

What is changed and how it works?

Raft: add logging about read index failure
*  also add a comment about one of the reason why read index timeout may happen

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Oct 22, 2025
@JaySon-Huang JaySon-Huang force-pushed the refine_read_index_process branch from 1fa2f10 to ea2bd63 Compare October 22, 2025 10:30
@JaySon-Huang JaySon-Huang changed the title [WIP] Raft: add logging about read index failure Raft: add logging about read index failure Oct 22, 2025
@ti-chi-bot ti-chi-bot bot removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. do-not-merge/needs-triage-completed labels Oct 22, 2025
@JaySon-Huang
clean outdate comment
e902df5 
Signed-off-by: JaySon-Huang <tshent@qq.com>
@JaySon-Huang
Fix typo of RuntimeFilterList
eb407fd 
Signed-off-by: JaySon-Huang <tshent@qq.com>
CalvinNeo
CalvinNeo approved these changes Oct 22, 2025
View reviewed changes
Copy link
Member

@CalvinNeo CalvinNeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Oct 22, 2025
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Oct 22, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: CalvinNeo, JinheLin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Oct 22, 2025
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Oct 22, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-10-22 14:21:18.649664282 +0000 UTC m=+881584.726916842: ☑️ agreed by CalvinNeo.
  • 2025-10-22 14:36:07.136904612 +0000 UTC m=+882473.214157162: ☑️ agreed by JinheLin.

@JaySon-Huang
Copy link
Contributor Author

JaySon-Huang commented Oct 22, 2025

/test pull-unit-test

@JaySon-Huang
Copy link
Contributor Author

JaySon-Huang commented Oct 22, 2025

/test pull-integration-test

@ti-chi-bot ti-chi-bot bot merged commit 35d2f9c into pingcap:master Oct 22, 2025
7 checks passed
@JaySon-Huang JaySon-Huang deleted the refine_read_index_process branch October 23, 2025 01:46
@JaySon-Huang
Copy link
Contributor Author

JaySon-Huang commented Oct 23, 2025

/cherry-pick release-nextgen-20251011

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Oct 23, 2025

@JaySon-Huang: new pull request created to branch release-nextgen-20251011: #10497.

Details

In response to this:

/cherry-pick release-nextgen-20251011

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot mentioned this pull request Oct 23, 2025
Merged
12 tasks
ti-chi-bot bot pushed a commit that referenced this pull request Oct 23, 2025
@ti-chi-bot @JaySon-Huang
Raft: add logging about read index failure (#10494) (#10497)
d1b8e6e 
close #10495

Raft: add logging about read index failure
*  also add a comment about one of the reason why read index timeout may happen

Signed-off-by: JaySon-Huang <tshent@qq.com>

Co-authored-by: JaySon-Huang <tshent@qq.com>
@ti-chi-bot ti-chi-bot bot added the needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. label Oct 30, 2025
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Oct 30, 2025

In response to a cherrypick label: new pull request created to branch release-8.5: #10516.
But this PR has conflicts, please resolve them!

ti-chi-bot pushed a commit to ti-chi-bot/tiflash that referenced this pull request Oct 30, 2025
@JaySon-Huang @ti-chi-bot
This is an automated cherry-pick of pingcap#10494
eff8c61 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot mentioned this pull request Oct 30, 2025
Closed
12 tasks
This was referenced Nov 10, 2025
Closed
Merged
Merged
This was referenced Nov 11, 2025
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@CalvinNeo CalvinNeo CalvinNeo approved these changes

@JinheLin JinheLin JinheLin approved these changes

@Lloyd-Pottiger Lloyd-Pottiger Awaiting requested review from Lloyd-Pottiger

Assignees

No one assigned

Labels

approved lgtm needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

TiFlash slow query cause by read index timeout

4 participants

@JaySon-Huang @ti-chi-bot @CalvinNeo @JinheLin