proxy: Update proxy of master for adding a read index config and some related logs#10514
Merged
ti-chi-bot[bot] merged 8 commits intopingcap:masterfrom Oct 30, 2025
Merged
Conversation
Signed-off-by: gengliqi <gengliqiii@gmail.com>
Contributor
|
/hold |
Signed-off-by: JaySon-Huang <tshent@qq.com>
Contributor
|
/unhold |
Contributor
[LGTM Timeline notifier]Timeline:
|
Contributor
|
/hold |
Signed-off-by: JaySon-Huang <tshent@qq.com>
Signed-off-by: gengliqi <gengliqiii@gmail.com>
Signed-off-by: JaySon-Huang <tshent@qq.com>
Contributor
|
/unhold |
Contributor
Author
|
/hold |
Signed-off-by: gengliqi <gengliqiii@gmail.com>
Contributor
Author
|
/unhold |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: CalvinNeo, JaySon-Huang The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: JaySon-Huang <tshent@qq.com>
Contributor
|
/test pull-integration-test |
Contributor
Author
|
/retest |
Member
|
In response to a cherrypick label: failed to apply #10514 on top of branch "release-8.5": |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #10495
Problem Summary:
What is changed and how it works?
In https://github.com/pingcap/tidb-engine-ext/pull/449/files, tiflash-proxy will retry the read-index request if it does not get response in 4 ticks.
Note that DEFAULT_BATCH_READ_INDEX_TIMEOUT_MS remain unchanged so that the cpp code will wait for 10 seconds for the tiflash-proxy internal retries.
Check List
Tests
Side effects
Documentation
Release note