Skip to content

*: Downgrade unnecessary log#10466

Merged
ti-chi-bot[bot] merged 4 commits intopingcap:masterfrom
JaySon-Huang:downgrade-log
Sep 30, 2025
Merged

*: Downgrade unnecessary log#10466
ti-chi-bot[bot] merged 4 commits intopingcap:masterfrom
JaySon-Huang:downgrade-log

Conversation

@JaySon-Huang
Copy link
Contributor

@JaySon-Huang JaySon-Huang commented Sep 30, 2025

What problem does this PR solve?

Issue Number: close #10467

Problem Summary: Reduce the logging with command.rs:169, which is about 33.5% of the total number of logging

What is changed and how it works?


Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Reduce unnecessary logging of handling raft commands

Signed-off-by: JaySon-Huang <tshent@qq.com>
Signed-off-by: JaySon-Huang <tshent@qq.com>
@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/needs-linked-issue release-note-none Denotes a PR that doesn't merit a release note. labels Sep 30, 2025
Copy link
Member

@CalvinNeo CalvinNeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Sep 30, 2025
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Sep 30, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: CalvinNeo, Lloyd-Pottiger

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [CalvinNeo,Lloyd-Pottiger]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Sep 30, 2025
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Sep 30, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-09-30 05:58:48.863796492 +0000 UTC m=+150709.120527893: ☑️ agreed by CalvinNeo.
  • 2025-09-30 05:58:55.627195528 +0000 UTC m=+150715.883926928: ☑️ agreed by Lloyd-Pottiger.

Signed-off-by: JaySon-Huang <tshent@qq.com>
@ti-chi-bot ti-chi-bot bot added the needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. label Sep 30, 2025
@JaySon-Huang
Copy link
Contributor Author

/test pull-integration-next-gen

1 similar comment
@JaySon-Huang
Copy link
Contributor Author

/test pull-integration-next-gen

@JaySon-Huang
Copy link
Contributor Author

/test pull-unit-next-gen

@ti-chi-bot ti-chi-bot bot merged commit 8a5e979 into pingcap:master Sep 30, 2025
7 checks passed
@JaySon-Huang JaySon-Huang deleted the downgrade-log branch September 30, 2025 08:52
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: failed to apply #10466 on top of branch "release-8.5":

[failed to git add conflicting files: exit status 128, failed to git commit: exit status 128]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved lgtm needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Reduce the number of useless logging of useless raft command

4 participants