Skip to content

Prefer local store for remote read coprocessor requests#10441

Merged
ti-chi-bot[bot] merged 5 commits intopingcap:masterfrom
gengliqi:remote-read-prefer-local
Sep 18, 2025
Merged

Prefer local store for remote read coprocessor requests#10441
ti-chi-bot[bot] merged 5 commits intopingcap:masterfrom
gengliqi:remote-read-prefer-local

Conversation

@gengliqi
Copy link
Contributor

@gengliqi gengliqi commented Sep 17, 2025 •
edited
Loading

What problem does this PR solve?

Issue Number: ref #10266, close #10440

Problem Summary:

What is changed and how it works?

Prefer local store for remote read coprocessor requests

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@gengliqi
prefer local for remote read
5d085d0 
Signed-off-by: gengliqi <gengliqiii@gmail.com>
@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 17, 2025
JaySon-Huang
JaySon-Huang reviewed Sep 17, 2025
View reviewed changes
gengliqi and others added 4 commits September 17, 2025 20:58
@gengliqi @JaySon-Huang
Update dbms/src/Flash/Coprocessor/DAGStorageInterpreter.cpp
2d5b4a4 
Co-authored-by: JaySon <tshent@qq.com>
@gengliqi
Merge remote-tracking branch 'upstream/master' into remote-read-prefe…
6456d4a 
…r-local
@gengliqi
update client-c
c15e01e 
Signed-off-by: gengliqi <gengliqiii@gmail.com>
@gengliqi
u
c53347b 
Signed-off-by: gengliqi <gengliqiii@gmail.com>
@ti-chi-bot ti-chi-bot bot added the needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. label Sep 18, 2025
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Sep 18, 2025
windtalker
windtalker approved these changes Sep 18, 2025
View reviewed changes
Copy link
Contributor

@windtalker windtalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Sep 18, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JaySon-Huang, windtalker

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [JaySon-Huang,windtalker]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Sep 18, 2025
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Sep 18, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-09-18 12:23:35.941483874 +0000 UTC m=+102577.420064521: ☑️ agreed by JaySon-Huang.
  • 2025-09-18 12:41:42.119643606 +0000 UTC m=+103663.598224273: ☑️ agreed by windtalker.

@ti-chi-bot ti-chi-bot bot merged commit 24fea33 into pingcap:master Sep 18, 2025
7 checks passed
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Sep 18, 2025

In response to a cherrypick label: failed to apply #10441 on top of branch "release-8.5":

[failed to git add conflicting files: exit status 128, failed to git commit: exit status 128]

@gengliqi
Copy link
Contributor Author

gengliqi commented Sep 18, 2025

/cherrypick release-8.5

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Sep 18, 2025

@gengliqi: failed to apply #10441 on top of branch "release-8.5":

[failed to git add conflicting files: exit status 128, failed to git commit: exit status 128]
Details

In response to this:

/cherrypick release-8.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@gengliqi gengliqi mentioned this pull request Sep 19, 2025
Merged
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@windtalker windtalker windtalker approved these changes

@JaySon-Huang JaySon-Huang JaySon-Huang approved these changes

Assignees

No one assigned

Labels

approved lgtm needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Prefer local store for remote read coprocessor requests

4 participants

@gengliqi @ti-chi-bot @windtalker @JaySon-Huang