Raft: Increase max retry times to avoid too large remote requests (#10301)#10309
Raft: Increase max retry times to avoid too large remote requests (#10301)#10309ti-chi-bot wants to merge 1 commit intopingcap:release-8.5from
Conversation
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
|
@JaySon-Huang This PR has conflicts, I have hold it. |
|
This cherry pick PR is for a release branch and has not yet been approved by triage owners. To merge this cherry pick:
DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@ti-chi-bot: ## If you want to know how to resolve it, please read the guide in TiDB Dev Guide. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
already done in #10302 |
This is an automated cherry-pick of #10301
What problem does this PR solve?
Issue Number: close #10300
Problem Summary:
In
DAGStorageInterpreter::buildLocalStreamsForPhysicalTablewe need to confirm the regions' keyranges not changed and regions are not removed before the storage snapshot is built. Otherwise the query result is incorrect.tiflash/dbms/src/Flash/Coprocessor/DAGStorageInterpreter.cpp
Lines 1069 to 1072 in bec1390
Building storage snapshot usually takes about a hundreds ms to few seconds. But the max retry time is only 1. If retry reach the max time, then all the Regions will be fetch though "RemoteRead". When querying a hot write large table, it could fail more than 1. And because the table is large, query contains large number of Regions, retrying all Regions in "RemoteRead" way could takes lots of network bandwidth and extra CPU, leading to TiFlash unstable.
What is changed and how it works?
Other changes:
ann_query_infoColumnFilePersistedSet::installCompactionResultsmeet unexpected exception.Check List
Tests
Side effects
Documentation
Release note