Raft: Increase max retry times to avoid too large remote requests (release-8.5)#10302
Merged
ti-chi-bot[bot] merged 1 commit intopingcap:release-8.5from Jul 11, 2025
Merged
Conversation
Signed-off-by: JaySon-Huang <tshent@qq.com>
JinheLin
approved these changes
Jul 11, 2025
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JinheLin, windtalker The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Contributor
[LGTM Timeline notifier]Timeline:
|
12 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cherry-pick of #10301
What problem does this PR solve?
Issue Number: close #10300
Problem Summary:
In
DAGStorageInterpreter::buildLocalStreamsForPhysicalTablewe need to confirm the regions' keyranges not changed and regions are not removed before the storage snapshot is built. Otherwise the query result is incorrect.tiflash/dbms/src/Flash/Coprocessor/DAGStorageInterpreter.cpp
Lines 1069 to 1072 in bec1390
Building storage snapshot usually takes about a hundreds ms to few seconds. But the max retry time is only 1. If retry reach the max time, then all the Regions will be fetch though "RemoteRead". When querying a hot write large table, it could fail more than 1. And because the table is large, query contains large number of Regions, retrying all Regions in "RemoteRead" way could takes lots of network bandwidth and extra CPU, leading to TiFlash unstable.
What is changed and how it works?
Other changes:
ann_query_infoColumnFilePersistedSet::installCompactionResultsmeet unexpected exception.Check List
Tests
Side effects
Documentation
Release note