Storages: refine download index file#10053
Conversation
| } | ||
| else | ||
| { | ||
| throw Exception(ErrorCodes::S3_ERROR, "Failed to download vector index file {}", index_file_path); |
There was a problem hiding this comment.
Why not throw exception in downloadFileForLocalReadWithRetry if failed?
[LGTM Timeline notifier]Timeline:
|
|
@Lloyd-Pottiger: Your PR was out of date, I have automatically updated it for you. At the same time I will also trigger all tests for you: /run-all-tests
If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
|
/hold |
7b925bc to
893a395
Compare
|
/retest |
|
/test pull-integration-test |
|
/retest-required |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: breezewish, CalvinNeo, JaySon-Huang The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/unhold |
1 similar comment
|
/unhold |
…ingcap#407) Signed-off-by: Wish <breezewish@outlook.com>
What problem does this PR solve?
Issue Number: ref #9843
Problem Summary:
What is changed and how it works?
Check List
Tests
Side effects
Documentation
Release note