Skip to content

fix(version): built version is always dirty#6544

Merged
ti-chi-bot[bot] merged 1 commit intopingcap:feature/v2from
liubog2008:liubo02/fix-git-version
Nov 15, 2025
Merged

fix(version): built version is always dirty#6544
ti-chi-bot[bot] merged 1 commit intopingcap:feature/v2from
liubog2008:liubo02/fix-git-version

Conversation

@liubog2008
Copy link
Member

  • Now built version in tidb-operator image is always dirty. Get version and then sending it into container builder

Signed-off-by: liubo02 <liubo02@pingcap.com>
@ti-chi-bot ti-chi-bot bot requested a review from shonge November 14, 2025 03:40
@github-actions github-actions bot added the v2 for operator v2 label Nov 14, 2025
@ti-chi-bot ti-chi-bot bot added the size/S label Nov 14, 2025
@codecov-commenter
Copy link

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 40.40%. Comparing base (d2bb446) to head (5922af0).

Additional details and impacted files
@@             Coverage Diff             @@
##           feature/v2    #6544   +/-   ##
===========================================
  Coverage       40.40%   40.40%           
===========================================
  Files             366      366           
  Lines           20357    20357           
===========================================
  Hits             8226     8226           
  Misses          12131    12131           
Flag Coverage Δ
unittest 40.40% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Nov 14, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fgksgf

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the lgtm label Nov 14, 2025
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Nov 14, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-11-14 03:58:11.129276721 +0000 UTC m=+1020140.572306600: ☑️ agreed by fgksgf.

@ti-chi-bot ti-chi-bot bot added the approved label Nov 14, 2025
@liubog2008
Copy link
Member Author

/test pull-e2e

1 similar comment
@liubog2008
Copy link
Member Author

/test pull-e2e

@ti-chi-bot ti-chi-bot bot merged commit a4059d0 into pingcap:feature/v2 Nov 15, 2025
9 checks passed
@liubog2008
Copy link
Member Author

/cherry-pick release-2.0

@ti-chi-bot
Copy link
Member

@liubog2008: new pull request created to branch release-2.0: #6546.

Details

In response to this:

/cherry-pick release-2.0

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants