fix(updater): ignore deleting instances in topology policy#6538
Merged
ti-chi-bot[bot] merged 2 commits intopingcap:feature/v2from Nov 11, 2025
Merged
fix(updater): ignore deleting instances in topology policy#6538ti-chi-bot[bot] merged 2 commits intopingcap:feature/v2from
ti-chi-bot[bot] merged 2 commits intopingcap:feature/v2from
Conversation
Signed-off-by: liubo02 <liubo02@pingcap.com>
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## feature/v2 #6538 +/- ##
==============================================
- Coverage 41.09% 41.08% -0.02%
==============================================
Files 366 366
Lines 20328 20348 +20
==============================================
+ Hits 8354 8360 +6
- Misses 11974 11988 +14
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
csuzhangxc
approved these changes
Nov 11, 2025
Contributor
[LGTM Timeline notifier]Timeline:
|
fgksgf
approved these changes
Nov 11, 2025
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: csuzhangxc, fgksgf The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
liubog2008
added a commit
to liubog2008/tidb-operator
that referenced
this pull request
Nov 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If an instance is deleting, it may still be count by topology policy. It makes the prefer policy unstable.