fix(pd): wrong image can be fixed after pdgroup is created#6536
fix(pd): wrong image can be fixed after pdgroup is created#6536ti-chi-bot[bot] merged 2 commits intopingcap:feature/v2from
Conversation
liubog2008
commented
Nov 6, 2025
- if image is wrong, pd cannot bootstrap and no status
- if no status, updater cannot update not running pd.
- if no enough running pd instance, the pd cluster cannot bootstrap
Signed-off-by: liubo02 <liubo02@pingcap.com>
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## feature/v2 #6536 +/- ##
===========================================
Coverage 40.99% 40.99%
===========================================
Files 366 366
Lines 20295 20294 -1
===========================================
Hits 8320 8320
+ Misses 11975 11974 -1
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Signed-off-by: liubo02 <liubo02@pingcap.com>
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the E2E test framework to improve code organization and reusability by introducing a new action package that consolidates common test operations like scaling, rolling restarts, and availability testing. The changes replace repetitive inline test code with reusable helper functions and update function signatures to use scope-based type parameters instead of runtime tuples.
Key changes:
- Introduced
tests/e2e/framework/actionpackage with reusable test action helpers (MustScale,MustRollingRestart,MustScaleAndRollingRestart, availability test functions) - Updated waiter functions to use scope-based type parameters and added support for condition checking with
ObservedGenerationvalidation - Refactored numerous test files to use the new action helpers, eliminating code duplication
- Added generated runtime methods
SetTemplateLabelsandSetTemplateAnnotationsfor all group types
Reviewed Changes
Copilot reviewed 44 out of 44 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| tests/e2e/framework/action/scale.go | New file with scale and update action helpers |
| tests/e2e/framework/action/test.go | New file with availability test helpers |
| tests/e2e/utils/waiter/pod.go | Updated function signatures to use scope-based generics |
| tests/e2e/utils/waiter/group.go | Added WaitForInstanceListCondition and ListCondition functions |
| tests/e2e/utils/waiter/common.go | Updated WaitForObjectCondition to validate ObservedGeneration |
| tests/e2e/tiproxy/tiproxy.go | Refactored to use new action helpers |
| tests/e2e/tidb/topology.go | Refactored to use new action helpers |
| tests/e2e/tidb/tidb.go | Refactored to use new action helpers |
| tests/e2e/tidb/standby.go | Updated to use action helpers |
| tests/e2e/ticdc/ticdc.go | Refactored to use new action helpers |
| tests/e2e/suite/scale/tikv.go | Refactored to use new action helpers |
| tests/e2e/suite/scale/pd.go | New test file for PD scaling scenarios |
| tests/e2e/suite/cluster/tls.go | Minor formatting fix |
| tests/e2e/suite/availability/*.go | Refactored to use new action helpers |
| tests/e2e/pd/pd.go | Simplified tests by removing redundant scale tests |
| tests/e2e/framework/*.go | Moved test helpers to action package, added generic wait functions |
| tests/e2e/data/*.go | Added utility functions for template annotations |
| pkg/runtime/*.go | Added generated setter methods for template labels/annotations |
| pkg/controllers/pd/*.go | Removed unused status check logic |
| pkg/apiutil/core/v1alpha1/group.go | Added template annotation utility functions |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
/lgtm |
[LGTM Timeline notifier]Timeline:
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fgksgf The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |