Don't write to rockdb when meet empty write batch#159
Merged
CalvinNeo merged 3 commits intopingcap:raftstore-proxy-6.2from Sep 5, 2022
Merged
Don't write to rockdb when meet empty write batch#159CalvinNeo merged 3 commits intopingcap:raftstore-proxy-6.2from
CalvinNeo merged 3 commits intopingcap:raftstore-proxy-6.2from
Conversation
breezewish
approved these changes
Sep 5, 2022
Merged
12 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: CalvinNeo calvinneo1995@gmail.com
What problem does this PR solve?
Issue Number: close pingcap/tiflash#5783
Problem Summary:
There is a vulnerability in TiKV that we may meet deadlock when try to write an empty
WriteBatchinto RocksDB, ifenable_pipelined_write = falseAka tikv/rocksdb#312
Though we don't know exactly which codes actually bring about this vulnerability, we can still prevent writes to rocksdb and print out a log trace.
What is changed and how it works?
Check List
Tests
Side effects
Documentation
Release note