fix writing empty batch in multi-batch mode#312
Merged
tabokie merged 1 commit intotikv:6.29.tikvfrom Aug 8, 2022
Merged
Conversation
Signed-off-by: tabokie <xy.tao@outlook.com>
Connor1996
reviewed
Aug 8, 2022
Member
Connor1996
left a comment
There was a problem hiding this comment.
How about
if (count == 0) continue;
Member
Author
|
@Connor1996 Ideally we should only handle memtable logic in this block. Adding a |
BusyJay
approved these changes
Aug 8, 2022
12 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this line,
memtable_write_cntis incremented regardless of whether the write batch is empty.rocksdb/db/db_impl/db_impl_write.cc
Line 241 in 98a80e9
It's then added to the global
pending_memtable_writes_counter:rocksdb/db/db_impl/db_impl_write.cc
Line 297 in 98a80e9
However, when it's empty, the
requestwon't be enqueued to the commit queue, and the counter will never be decremented properly here:rocksdb/db/db_impl/db_impl_write.cc
Lines 123 to 125 in 98a80e9
As a result, a later write will potentially block on
WaitForPendingWritesforever.Signed-off-by: tabokie xy.tao@outlook.com