server: add /debug/zip api to get useful debuginfo at once#9651
Merged
tiancaiamao merged 5 commits intopingcap:masterfrom Mar 20, 2019
lysu:dev-one-key-pprof
Merged
server: add /debug/zip api to get useful debuginfo at once#9651tiancaiamao merged 5 commits intopingcap:masterfrom lysu:dev-one-key-pprof
/debug/zip api to get useful debuginfo at once#9651tiancaiamao merged 5 commits intopingcap:masterfrom
lysu:dev-one-key-pprof
Conversation
Codecov Report
@@ Coverage Diff @@
## master #9651 +/- ##
================================================
- Coverage 67.2409% 67.1757% -0.0652%
================================================
Files 381 381
Lines 79874 79944 +70
================================================
- Hits 53708 53703 -5
- Misses 21381 21451 +70
- Partials 4785 4790 +5 |
jackysp
reviewed
Mar 12, 2019
Contributor
jackysp
left a comment
There was a problem hiding this comment.
Great!
Please add it to the doc file.
Contributor
|
PTAL @tiancaiamao |
Contributor
|
LGTM |
Contributor
|
/run-all-tests |
tiancaiamao
approved these changes
Mar 20, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
when we do troubleshooting often need multiple round-trips to get info from our custom.
to save time we need the ability to get more info at once, just curl or access
http://0.0.0.0:10080/debug/zip
What is changed and how it works?
get go pprof info in one file and maybe we can add more info in future, now after unzip we will got:
Check List
Tests
can be curl and unzip and be
go pproforcatwithout errorCode changes
Side effects
Related changes
This change is